linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [BISECTED REGRESSION] OMAP1 GPIO breakage
Date: Thu, 4 May 2023 14:45:21 +0200	[thread overview]
Message-ID: <20230504144521.1b3a3574@aktux> (raw)
In-Reply-To: <CACRpkdY9ShRATHa776KyzeArmQdKxdwGxJC11YnmhWiCdSGzEA@mail.gmail.com>

Hi,

On Thu, 4 May 2023 14:13:32 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Thu, May 4, 2023 at 7:52 AM Tony Lindgren <tony@atomide.com> wrote:
> > * Tony Lindgren <tony@atomide.com> [230426 07:20]:  
> > > Seems that we should just revert this patch for now and try again after
> > > the issues have been fixed.  
> >
> > Looking at the proposed fixes being posted seems like they are quite
> > intrusive.. How about we partially revert this patch so omap1 still
> > uses static assigment of gpios?  
> 
> I think Andreas patch (commit 92bf78b33b0b463b00c6b0203b49aea845daecc8)
> kind of describes the problem with that: the probe order is now unpredictable,
> so if we revert the patch then that problem returns, but I don't know how
> serious that problem is.
> 
well, I think we can even fully revert 92bf78b33b0b463b00c6b0203b49aea845daecc8
after my patch

gpiolib: fix allocation of mixed dynamic/static GPIOs

is in as a short time solution. That should only leave unpredictable
numbers of multiple dynamic gpio controllers.

Regards,
Andrea

  reply	other threads:[~2023-05-04 12:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 17:32 [BISECTED REGRESSION] OMAP1 GPIO breakage Aaro Koskinen
2023-04-25 18:11 ` Andreas Kemnade
2023-04-25 18:38   ` Aaro Koskinen
2023-04-25 19:20     ` Andreas Kemnade
2023-04-25 19:36       ` Aaro Koskinen
2023-04-25 19:58         ` Andreas Kemnade
2023-04-26  7:19           ` Tony Lindgren
2023-04-26  7:39             ` Andreas Kemnade
2023-04-26 10:52               ` andy.shevchenko
2023-04-26 18:29                 ` Andreas Kemnade
2023-04-26 20:36             ` Linus Walleij
2023-04-27  7:03               ` Tony Lindgren
2023-04-27  8:38                 ` Bartosz Golaszewski
2023-05-04  5:51             ` Tony Lindgren
2023-05-04 12:13               ` Linus Walleij
2023-05-04 12:45                 ` Andreas Kemnade [this message]
2023-05-05  8:38                   ` Tony Lindgren
2023-04-26 20:12     ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230504144521.1b3a3574@aktux \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).