From: Bjorn Andersson <andersson@kernel.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: agross@kernel.org, konrad.dybcio@linaro.org,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com,
manivannan.sadhasivam@linaro.org, andy.shevchenko@gmail.com,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v7 2/4] pinctrl: qcom: Remove the msm_function struct
Date: Thu, 11 May 2023 09:33:52 -0700 [thread overview]
Message-ID: <20230511163352.kfjpvagh2rysyelo@ripper> (raw)
In-Reply-To: <1683730825-15668-3-git-send-email-quic_rohiagar@quicinc.com>
On Wed, May 10, 2023 at 08:30:23PM +0530, Rohit Agarwal wrote:
> Remove the msm_function struct to reuse the generic pinfunction
> struct. Also, define a generic PINFUNCTION macro that can be used across
> qcom target specific pinctrl files to avoid code repetition.
>
Looks nice! No need to carry our own structs for things that has made it
into the framework.
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
But, ipq9574.c has made it into linux-next now, so this breaks the build
of that driver. So please update this patch. And please send the two
refactoring patches on their own, followed by the SDX75 based on that,
so we can get those merged quickly, before any other impediments are
introduced.
Regards,
Bjorn
next prev parent reply other threads:[~2023-05-11 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 15:00 [PATCH v7 0/4] Add pinctrl support for SDX75 Rohit Agarwal
2023-05-10 15:00 ` [PATCH v7 1/4] dt-bindings: pinctrl: qcom: Add SDX75 pinctrl devicetree compatible Rohit Agarwal
2023-05-10 15:00 ` [PATCH v7 2/4] pinctrl: qcom: Remove the msm_function struct Rohit Agarwal
2023-05-11 16:33 ` Bjorn Andersson [this message]
2023-05-12 8:56 ` Rohit Agarwal
2023-05-10 15:00 ` [PATCH v7 3/4] pinctrl: qcom: Refactor generic qcom pinctrl driver Rohit Agarwal
2023-05-11 16:34 ` Bjorn Andersson
2023-05-10 15:00 ` [PATCH v7 4/4] pinctrl: qcom: Add SDX75 pincontrol driver Rohit Agarwal
2023-05-11 16:46 ` Bjorn Andersson
2023-05-12 8:57 ` Rohit Agarwal
2023-05-11 13:36 ` [PATCH v7 0/4] Add pinctrl support for SDX75 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511163352.kfjpvagh2rysyelo@ripper \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).