From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5D3AC77B7F for ; Fri, 12 May 2023 15:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241381AbjELPm2 (ORCPT ); Fri, 12 May 2023 11:42:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbjELPm1 (ORCPT ); Fri, 12 May 2023 11:42:27 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 116593C15; Fri, 12 May 2023 08:42:26 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34CF3372001679; Fri, 12 May 2023 10:42:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=B37wweTi8+RlFLIzQLpjB1FktiSxeiJrAjQf//Y2odQ=; b=KVcz6XNPSCRthYUSHmT9pCqQ/9v8qMphPkZgTyE+EZpgPhFAXkh44hX6uN/U5yD2Idx2 qaQ27W69Ta/X3HyjdqoAPw1zzB0hIdirel6wrB6iQgIqRecq3FCiAM6i9DRsz8iaVs/A 7/25+FGyInLFZrS6Jir0sG/usD5fvdfv9lfSY0XXOOjB6A0mZUpaSfziMPG3/4RiLYuP 8CZ5Z0SWQfPnbYmuESuNe/NKookFvLi3txnBcHX9mik1wszm1FDo+uNLIvKUX+Z1O8gX sS1wNDArZojp1pBhG5xfuMLjMWBbe5tIPFqu7QCEs87hNuMTbeUUNvjJrwrhiY8lo2Qu qw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3qf7nb5n9d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 May 2023 10:42:12 -0500 Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 12 May 2023 10:42:10 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 12 May 2023 10:42:10 -0500 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 62A4A15A4; Fri, 12 May 2023 15:42:10 +0000 (UTC) Date: Fri, 12 May 2023 15:42:10 +0000 From: Charles Keepax To: Pierre-Louis Bossart CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 03/10] ASoC: ak4118: Update to use new component control notify helper Message-ID: <20230512154210.GI68926@ediswmail.ad.cirrus.com> References: <20230512122838.243002-1-ckeepax@opensource.cirrus.com> <20230512122838.243002-4-ckeepax@opensource.cirrus.com> <138e5c73-c33b-806a-b64e-5c93aaefb140@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <138e5c73-c33b-806a-b64e-5c93aaefb140@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-ORIG-GUID: xhtMFVwhjVBZv_0DgtBEWA0ofRcdVbya X-Proofpoint-GUID: xhtMFVwhjVBZv_0DgtBEWA0ofRcdVbya X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, May 12, 2023 at 08:48:40AM -0500, Pierre-Louis Bossart wrote: > On 5/12/23 07:28, Charles Keepax wrote: > > Update the driver to use the new ASoC core control notify helper. > > This also fixes a bug where the control would not be found if the > > CODEC was given a name prefix. > > > > Signed-off-by: Charles Keepax > > --- > > sound/soc/codecs/ak4118.c | 11 ++--------- > > 1 file changed, 2 insertions(+), 9 deletions(-) > > > > diff --git a/sound/soc/codecs/ak4118.c b/sound/soc/codecs/ak4118.c > > should patches 2, 3, 4 be part of a separate series, they really have > nothing to do with the Cirrus CS32L43? Patch 2 has a build dependency on the CODEC patch, 3/4 are debatable. I could do the series without these patches and do a seperate chain with those three patches and an extra patch to convert the cs42l43, if that is preferred to shrink the chain. Thanks, Charles