* [PATCH 2/2] serial: sc16is7xx: fix regression with GPIO configuration
2023-05-17 15:07 [PATCH 1/2] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
@ 2023-05-17 15:07 ` Hugo Villeneuve
2023-05-17 17:25 ` [PATCH 1/2] dt-bindings: sc16is7xx: Add property to change GPIO function Conor Dooley
1 sibling, 0 replies; 4+ messages in thread
From: Hugo Villeneuve @ 2023-05-17 15:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Lech Perczak, Tomasz Moń
Cc: hugo, linux-gpio, Hugo Villeneuve, linux-serial, linux-kernel
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Commit 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines")
and commit 21144bab4f11 ("sc16is7xx: Handle modem status lines")
changed the function of the GPIOs pins to act as modem control
lines without any possibility of selecting GPIO function.
As a consequence, applications that depends on GPIO lines configured
by default as GPIO pins no longer work as expected.
Also, the change to select modem control lines function was done only
for channel A of dual UART variants (752/762). This was not documented
in the log message.
This new patch allows to specify GPIO or modem control line function
in the device tree, and for each of the ports (A or B).
This is done by using the new device-tree property named
"modem-control-line-ports" (property added in separate patch).
Boards that need to have GPIOS configured as modem control lines
should add that property to their device tree. Here is a list of
boards using the sc16is7xx driver in their device tree and that may
need to be modified:
arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
mips/boot/dts/ingenic/cu1830-neo.dts
mips/boot/dts/ingenic/cu1000-neo.dts
Fixes: 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines")
Fixes: 21144bab4f11 ("sc16is7xx: Handle modem status lines")
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
drivers/tty/serial/sc16is7xx.c | 42 ++++++++++++++++++++--------------
1 file changed, 25 insertions(+), 17 deletions(-)
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index a7c4da3cfd2b..1a3143331c1f 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -236,7 +236,8 @@
/* IOControl register bits (Only 75x/76x) */
#define SC16IS7XX_IOCONTROL_LATCH_BIT (1 << 0) /* Enable input latching */
-#define SC16IS7XX_IOCONTROL_MODEM_BIT (1 << 1) /* Enable GPIO[7:4] as modem pins */
+#define SC16IS7XX_IOCONTROL_MODEM_A_BIT (1 << 1) /* Enable GPIO[7:4] as modem A pins */
+#define SC16IS7XX_IOCONTROL_MODEM_B_BIT (1 << 2) /* Enable GPIO[3:0] as modem B pins */
#define SC16IS7XX_IOCONTROL_SRESET_BIT (1 << 3) /* Software Reset */
/* EFCR register bits */
@@ -306,7 +307,6 @@ struct sc16is7xx_devtype {
char name[10];
int nr_gpio;
int nr_uart;
- int has_mctrl;
};
#define SC16IS7XX_RECONF_MD (1 << 0)
@@ -447,35 +447,30 @@ static const struct sc16is7xx_devtype sc16is74x_devtype = {
.name = "SC16IS74X",
.nr_gpio = 0,
.nr_uart = 1,
- .has_mctrl = 0,
};
static const struct sc16is7xx_devtype sc16is750_devtype = {
.name = "SC16IS750",
- .nr_gpio = 4,
+ .nr_gpio = 8,
.nr_uart = 1,
- .has_mctrl = 1,
};
static const struct sc16is7xx_devtype sc16is752_devtype = {
.name = "SC16IS752",
- .nr_gpio = 0,
+ .nr_gpio = 8,
.nr_uart = 2,
- .has_mctrl = 1,
};
static const struct sc16is7xx_devtype sc16is760_devtype = {
.name = "SC16IS760",
- .nr_gpio = 4,
+ .nr_gpio = 8,
.nr_uart = 1,
- .has_mctrl = 1,
};
static const struct sc16is7xx_devtype sc16is762_devtype = {
.name = "SC16IS762",
- .nr_gpio = 0,
+ .nr_gpio = 8,
.nr_uart = 2,
- .has_mctrl = 1,
};
static bool sc16is7xx_regmap_volatile(struct device *dev, unsigned int reg)
@@ -1457,12 +1452,6 @@ static int sc16is7xx_probe(struct device *dev,
SC16IS7XX_EFCR_RXDISABLE_BIT |
SC16IS7XX_EFCR_TXDISABLE_BIT);
- /* Use GPIO lines as modem status registers */
- if (devtype->has_mctrl)
- sc16is7xx_port_write(&s->p[i].port,
- SC16IS7XX_IOCONTROL_REG,
- SC16IS7XX_IOCONTROL_MODEM_BIT);
-
/* Initialize kthread work structs */
kthread_init_work(&s->p[i].tx_work, sc16is7xx_tx_proc);
kthread_init_work(&s->p[i].reg_work, sc16is7xx_reg_proc);
@@ -1498,6 +1487,25 @@ static int sc16is7xx_probe(struct device *dev,
prop, p, u)
if (u < devtype->nr_uart)
s->p[u].irda_mode = true;
+
+ val = 0;
+
+ of_property_for_each_u32(dev->of_node, "modem-control-line-ports",
+ prop, p, u)
+ if (u < devtype->nr_uart) {
+ /* Use GPIO lines as modem control lines */
+ if (u == 0)
+ val |= SC16IS7XX_IOCONTROL_MODEM_A_BIT;
+ else if (u == 1)
+ val |= SC16IS7XX_IOCONTROL_MODEM_B_BIT;
+ }
+
+ if (val)
+ regmap_update_bits(
+ s->regmap,
+ SC16IS7XX_IOCONTROL_REG << SC16IS7XX_REG_SHIFT,
+ SC16IS7XX_IOCONTROL_MODEM_A_BIT |
+ SC16IS7XX_IOCONTROL_MODEM_B_BIT, val);
}
#ifdef CONFIG_GPIOLIB
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] dt-bindings: sc16is7xx: Add property to change GPIO function
2023-05-17 15:07 [PATCH 1/2] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-05-17 15:07 ` [PATCH 2/2] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
@ 2023-05-17 17:25 ` Conor Dooley
2023-05-18 13:30 ` Hugo Villeneuve
1 sibling, 1 reply; 4+ messages in thread
From: Conor Dooley @ 2023-05-17 17:25 UTC (permalink / raw)
To: Hugo Villeneuve
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-gpio, Hugo Villeneuve, linux-serial,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
On Wed, May 17, 2023 at 11:07:46AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Some variants in this series of uart controllers have GPIO pins that
> are shared between GPIO and modem control lines.
>
> The pin mux mode (GPIO or modem control lines) can be set for each
> ports (channels) supported by the variant.
>
> This adds a property to the device tree to set the GPIO pin mux to
> modem control lines on selected ports if needed.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> .../bindings/serial/nxp,sc16is7xx.txt | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> index 0fa8e3e43bf8..426b7285ad50 100644
> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> @@ -23,6 +23,9 @@ Optional properties:
> 1 = active low.
> - irda-mode-ports: An array that lists the indices of the port that
> should operate in IrDA mode.
> +- modem-control-line-ports: An array that lists the indices of the port that
> + should have shared GPIO lines configured as modem
> + control lines.
If this is an NXP specific property, should it not have an nxp, vendor
prefix?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread