* [PATCH v5 11/44] gpio: add HAS_IOPORT dependencies
[not found] <20230522105049.1467313-1-schnelle@linux.ibm.com>
@ 2023-05-22 10:50 ` Niklas Schnelle
2023-05-23 8:15 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Schnelle @ 2023-05-22 10:50 UTC (permalink / raw)
To: Arnd Bergmann, Linus Walleij, Bartosz Golaszewski
Cc: Greg Kroah-Hartman, Bjorn Helgaas, Uwe Kleine-König,
Mauro Carvalho Chehab, Alan Stern, Rafael J. Wysocki,
Geert Uytterhoeven, Paul Walmsley, Palmer Dabbelt, Albert Ou,
linux-kernel, linux-arch, linux-pci, Arnd Bergmann, linux-gpio
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
not being declared. We thus need to add HAS_IOPORT as dependency for
those drivers using them.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Co-developed-by: Arnd Bergmann <arnd@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@kernel.org>
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
---
drivers/gpio/Kconfig | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 5521f060d58e..a470ec8d617b 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -704,18 +704,6 @@ config GPIO_VISCONTI
help
Say yes here to support GPIO on Tohisba Visconti.
-config GPIO_VX855
- tristate "VIA VX855/VX875 GPIO"
- depends on (X86 || COMPILE_TEST) && PCI
- select MFD_CORE
- select MFD_VX855
- help
- Support access to the VX855/VX875 GPIO lines through the GPIO library.
-
- This driver provides common support for accessing the device.
- Additional drivers must be enabled in order to use the
- functionality of the device.
-
config GPIO_WCD934X
tristate "Qualcomm Technologies Inc WCD9340/WCD9341 GPIO controller driver"
depends on MFD_WCD934X && OF_GPIO
@@ -835,7 +823,19 @@ config GPIO_IDT3243X
endmenu
menu "Port-mapped I/O GPIO drivers"
- depends on X86 # Unconditional I/O space access
+ depends on X86 && HAS_IOPORT # I/O space access
+
+config GPIO_VX855
+ tristate "VIA VX855/VX875 GPIO"
+ depends on PCI
+ select MFD_CORE
+ select MFD_VX855
+ help
+ Support access to the VX855/VX875 GPIO lines through the GPIO library.
+
+ This driver provides common support for accessing the device.
+ Additional drivers must be enabled in order to use the
+ functionality of the device.
config GPIO_I8255
tristate
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v5 11/44] gpio: add HAS_IOPORT dependencies
2023-05-22 10:50 ` [PATCH v5 11/44] gpio: add HAS_IOPORT dependencies Niklas Schnelle
@ 2023-05-23 8:15 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-05-23 8:15 UTC (permalink / raw)
To: Niklas Schnelle
Cc: Arnd Bergmann, Linus Walleij, Greg Kroah-Hartman, Bjorn Helgaas,
Uwe Kleine-König, Mauro Carvalho Chehab, Alan Stern,
Rafael J. Wysocki, Geert Uytterhoeven, Paul Walmsley,
Palmer Dabbelt, Albert Ou, linux-kernel, linux-arch, linux-pci,
Arnd Bergmann, linux-gpio
On Mon, May 22, 2023 at 12:51 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote:
>
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> drivers/gpio/Kconfig | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5521f060d58e..a470ec8d617b 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -704,18 +704,6 @@ config GPIO_VISCONTI
> help
> Say yes here to support GPIO on Tohisba Visconti.
>
> -config GPIO_VX855
> - tristate "VIA VX855/VX875 GPIO"
> - depends on (X86 || COMPILE_TEST) && PCI
> - select MFD_CORE
> - select MFD_VX855
> - help
> - Support access to the VX855/VX875 GPIO lines through the GPIO library.
> -
> - This driver provides common support for accessing the device.
> - Additional drivers must be enabled in order to use the
> - functionality of the device.
> -
> config GPIO_WCD934X
> tristate "Qualcomm Technologies Inc WCD9340/WCD9341 GPIO controller driver"
> depends on MFD_WCD934X && OF_GPIO
> @@ -835,7 +823,19 @@ config GPIO_IDT3243X
> endmenu
>
> menu "Port-mapped I/O GPIO drivers"
> - depends on X86 # Unconditional I/O space access
> + depends on X86 && HAS_IOPORT # I/O space access
> +
> +config GPIO_VX855
> + tristate "VIA VX855/VX875 GPIO"
> + depends on PCI
> + select MFD_CORE
> + select MFD_VX855
> + help
> + Support access to the VX855/VX875 GPIO lines through the GPIO library.
> +
> + This driver provides common support for accessing the device.
> + Additional drivers must be enabled in order to use the
> + functionality of the device.
>
> config GPIO_I8255
> tristate
> --
> 2.39.2
>
I already applied v4. Has this changed since the last version? If not,
then you can drop it now from your series.
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-23 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230522105049.1467313-1-schnelle@linux.ibm.com>
2023-05-22 10:50 ` [PATCH v5 11/44] gpio: add HAS_IOPORT dependencies Niklas Schnelle
2023-05-23 8:15 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).