From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B9AC77B7E for ; Sun, 28 May 2023 16:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbjE1Q5M (ORCPT ); Sun, 28 May 2023 12:57:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbjE1Q5L (ORCPT ); Sun, 28 May 2023 12:57:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAC9FAD; Sun, 28 May 2023 09:57:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 717A76112E; Sun, 28 May 2023 16:57:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6F60C433EF; Sun, 28 May 2023 16:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685293029; bh=+hWlogpsHCsoKplEv/92cr5w/RkOgzEL9FTtd9IUdlA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vE/zGI6PJoizrumVsABEYxWZWkx8NssyJ8jedEzsoTKTu2P91Z7zKOqGTY/t5LRwO vxwIoxcigc2J8mjbzCzA3c2AUZpCbFRTYAiG2OZW3NyMWyZ/fHWqZ2mC3yfWh2BU1S fdtt28fjgYscnYHQAh6tQS31vjDFyqAJdrP8HvOwuxNsD1aMNamwkHJqZAlWOWpNNF XqcSzFaWqmkBmD/uJuZXNoXlZa43UVIdFrUXZpM93NKu9DSvBNUGurdssDsxETI2Mo r55oVQgTw/qb9/fagyXMH1Yv57zvtCG3jR6D6zAawFMt108KTZdETGe6mU9mOb0A0p Hm3cV3AKBKJ6g== Date: Sun, 28 May 2023 18:13:25 +0100 From: Jonathan Cameron To: Matti Vaittinen Cc: Matti Vaittinen , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v6 5/8] pinctrl: ingenic: relax return value check for IRQ get Message-ID: <20230528181325.405d9dad@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, 26 May 2023 09:38:39 +0300 Matti Vaittinen wrote: > fwnode_irq_get[_byname]() were changed to not return 0 anymore. > > Drop check for return value 0. > > Signed-off-by: Matti Vaittinen > Reviewed-by: Paul Cercueil > Acked-by: Linus Walleij > Reviewed-by: Jonathan Cameron > --- > Revision history: > - No changes > > Please note, I took Linus' reply to v4 cover-letter as ack && added the > tag. Please let me know if this was not Ok. > > The first patch of the series changes the fwnode_irq_get() so this depends > on the first patch of the series and should not be applied alone. > --- > drivers/pinctrl/pinctrl-ingenic.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c > index 2f220a47b749..86e71ad703a5 100644 > --- a/drivers/pinctrl/pinctrl-ingenic.c > +++ b/drivers/pinctrl/pinctrl-ingenic.c > @@ -4201,8 +4201,6 @@ static int __init ingenic_gpio_probe(struct ingenic_pinctrl *jzpc, > err = fwnode_irq_get(fwnode, 0); > if (err < 0) > return err; > - if (!err) > - return -EINVAL; > jzgc->irq = err; > > girq = &jzgc->gc.irq;