From: Viresh Kumar <viresh.kumar@linaro.org>
To: Erik Schilling <erik.schilling@linaro.org>
Cc: Linux-GPIO <linux-gpio@vger.kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH libgpiod v2 0/2] bindings: rust: allow packaging of libgpiod-sys
Date: Mon, 29 May 2023 10:31:00 +0530 [thread overview]
Message-ID: <20230529050100.vgrzdcawkqcbehea@vireshk-i7> (raw)
In-Reply-To: <20230522-crates-io-v2-0-d8de75e7f584@linaro.org>
On 26-05-23, 17:27, Erik Schilling wrote:
> As of now, the Rust bindings are only consumable as git dependencies
> (and even then come with some restrictions when wanting to control
> the build and linkage behaviour).
>
> This series does some cleanup and then proposes a change in how the Rust
> bindings are built and linked in order to prepare libgpiod-sys (and thus
> also libgpiod) for being packageable via `cargo package` (which is a
> prerequisite for eventually publishing to crates.io).
>
> Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> ---
> Changes in v2:
> - Added wrapper.h that I forgot in v1 (Thanks Viresh!)
> - Rebased on top of the commits that already got merged as part of v1
> - Automatically set the right flags when using `make`
> - Tweaked the docs (setting the flags is now done automatically, so it
> is not as important anymore)
> - Link to v1: https://lore.kernel.org/r/20230522-crates-io-v1-0-42eeee775eb6@linaro.org
>
> ---
> Erik Schilling (2):
> rust: bindings: turn SPDX tags into comments
> bindings: rust: build against pkg-config info
>
> README | 4 +++-
> bindings/rust/gpiosim-sys/README.md | 8 ++++---
> bindings/rust/libgpiod-sys/Cargo.toml | 4 ++++
> bindings/rust/libgpiod-sys/README.md | 16 +++++++++++---
> bindings/rust/libgpiod-sys/build.rs | 40 +++++++++++++++++++++++------------
> bindings/rust/libgpiod-sys/wrapper.h | 1 +
> bindings/rust/libgpiod/Makefile.am | 8 ++++++-
> 7 files changed, 59 insertions(+), 22 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2023-05-29 5:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 15:27 [PATCH libgpiod v2 0/2] bindings: rust: allow packaging of libgpiod-sys Erik Schilling
2023-05-26 15:27 ` [PATCH libgpiod v2 1/2] rust: bindings: turn SPDX tags into comments Erik Schilling
2023-05-30 16:05 ` Bartosz Golaszewski
2023-05-26 15:27 ` [PATCH libgpiod v2 2/2] bindings: rust: build against pkg-config info Erik Schilling
2023-05-30 16:04 ` Bartosz Golaszewski
2023-05-30 16:27 ` Manos Pitsidianakis
2023-05-30 19:04 ` Bartosz Golaszewski
2023-05-31 6:17 ` Erik Schilling
2023-05-29 5:01 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529050100.vgrzdcawkqcbehea@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=erik.schilling@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=manos.pitsidianakis@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox