Re: [PATCH v1 1/2] pinctrl: moorefield: Fix open-drain pin mode configuration

Mika Westerberg
2023-06-06T05:15:49Z

On Mon, Jun 05, 2023 at 06:45:22PM +0300, Andy Shevchenko wrote:
> Currently the pin may not be configured as open-drain in some
> cases because the argument may be 0 for the boolean types of
> the pin configurations. Fix this by ignoring the argument.
>
> With that, allow to actually restore pin to the push-pull mode.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

BTW, looking at the two drivers they seem to have a lot of
commonalities. Perhaps it makes sense to consolidate?