From: Raag Jadav <raag.jadav@intel.com>
To: linus.walleij@linaro.org, mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v1 2/2] pinctrl: cherryview: simplify exit path of gpio_request_enable hook
Date: Thu, 8 Jun 2023 12:49:03 +0530 [thread overview]
Message-ID: <20230608071903.19170-3-raag.jadav@intel.com> (raw)
In-Reply-To: <20230608071903.19170-1-raag.jadav@intel.com>
Simplify exit path of ->gpio_request_enable() hook and save a few bytes.
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10)
Function old new delta
chv_gpio_request_enable 296 286 -10
Total: Before=19199, After=19189, chg -0.05%
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index 1e21c6f8aa7f..8dbe92cd1c21 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -803,15 +803,18 @@ static int chv_gpio_request_enable(struct pinctrl_dev *pctldev,
struct intel_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
unsigned long flags;
u32 value;
+ int ret;
+
+ /* For positive cases */
+ ret = 0;
raw_spin_lock_irqsave(&chv_lock, flags);
if (chv_pad_locked(pctrl, offset)) {
value = chv_readl(pctrl, offset, CHV_PADCTRL0);
if (!(value & CHV_PADCTRL0_GPIOEN)) {
- /* Locked so cannot enable */
- raw_spin_unlock_irqrestore(&chv_lock, flags);
- return -EBUSY;
+ ret = -EBUSY;
+ goto out_unlock;
}
} else {
struct intel_community_context *cctx = &pctrl->context.communities[0];
@@ -845,9 +848,10 @@ static int chv_gpio_request_enable(struct pinctrl_dev *pctldev,
chv_writel(pctrl, offset, CHV_PADCTRL0, value);
}
+out_unlock:
raw_spin_unlock_irqrestore(&chv_lock, flags);
- return 0;
+ return ret;
}
static void chv_gpio_disable_free(struct pinctrl_dev *pctldev,
--
2.17.1
next prev parent reply other threads:[~2023-06-08 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:19 [PATCH v1 0/2] Minor optimizations for Cherryview pinctrl Raag Jadav
2023-06-08 7:19 ` [PATCH v1 1/2] pinctrl: cherryview: simplify exit path of set_mux hook Raag Jadav
2023-06-08 7:19 ` Raag Jadav [this message]
2023-06-08 8:12 ` [PATCH v1 0/2] Minor optimizations for Cherryview pinctrl Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608071903.19170-3-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pandith.n@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).