From: Raag Jadav <raag.jadav@intel.com>
To: linus.walleij@linaro.org, mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v2 1/4] pinctrl: intel: refine set_mux hook
Date: Fri, 9 Jun 2023 13:55:36 +0530 [thread overview]
Message-ID: <20230609082539.24311-2-raag.jadav@intel.com> (raw)
In-Reply-To: <20230609082539.24311-1-raag.jadav@intel.com>
Utilize a temporary variable for common shift operation
inside ->set_mux() hook and improve readability.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index c7a71c49df0a..e8adf2580321 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -411,18 +411,19 @@ static int intel_pinmux_set_mux(struct pinctrl_dev *pctldev,
/* Now enable the mux setting for each pin in the group */
for (i = 0; i < grp->grp.npins; i++) {
void __iomem *padcfg0;
- u32 value;
+ u32 value, pmode;
padcfg0 = intel_get_padcfg(pctrl, grp->grp.pins[i], PADCFG0);
- value = readl(padcfg0);
+ value = readl(padcfg0);
value &= ~PADCFG0_PMODE_MASK;
if (grp->modes)
- value |= grp->modes[i] << PADCFG0_PMODE_SHIFT;
+ pmode = grp->modes[i];
else
- value |= grp->mode << PADCFG0_PMODE_SHIFT;
+ pmode = grp->mode;
+ value |= pmode << PADCFG0_PMODE_SHIFT;
writel(value, padcfg0);
}
--
2.17.1
next prev parent reply other threads:[~2023-06-09 8:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:25 [PATCH v2 0/4] Minor improvements for Intel pinctrl Raag Jadav
2023-06-09 8:25 ` Raag Jadav [this message]
2023-06-09 16:41 ` [PATCH v2 1/4] pinctrl: intel: refine set_mux hook Andy Shevchenko
2023-06-12 7:15 ` Jadav, Raag
2023-06-12 15:17 ` Andy Shevchenko
2023-06-09 8:25 ` [PATCH v2 2/4] pinctrl: intel: refine irq_set_type hook Raag Jadav
2023-06-09 8:25 ` [PATCH v2 3/4] pinctrl: intel: simplify exit path of set_mux hook Raag Jadav
2023-06-09 8:35 ` Mika Westerberg
2023-06-09 9:10 ` Jadav, Raag
2023-06-09 9:29 ` Mika Westerberg
2023-06-09 8:25 ` [PATCH v2 4/4] pinctrl: intel: simplify exit path of gpio_request_enable hook Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609082539.24311-2-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pandith.n@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox