Re: [PATCH v2 3/4] pinctrl: intel: simplify exit path of set_mux hook

Mika Westerberg
2023-06-09T09:35:27Z

On Fri, Jun 09, 2023 at 09:10:42AM +0000, Jadav, Raag wrote:
> > On Fri, Jun 09, 2023 at 01:55:38PM +0530, Raag Jadav wrote:
> > > Simplify exit path of ->set_mux() hook and save a few bytes.
> > >
> > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-22 (-22)
> > > Function old new delta
> > > intel_pinmux_set_mux 242 220 -22
> > > Total: Before=10453, After=10431, chg -0.21%
> > >
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > > drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++----
> > > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > This adds one more line so it is not simplifying ;-)
>
> Would "optimize" sound any better?

No, I think this patch is not useful at all.