* [PATCH] pinctrl: mlxbf3: remove broken Kconfig 'select'
@ 2023-06-19 8:20 Arnd Bergmann
2023-06-19 8:51 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-06-19 8:20 UTC (permalink / raw)
To: Linus Walleij
Cc: Arnd Bergmann, Andy Shevchenko, Colin Foster, Lee Jones,
Lakshmi Sowjanya D, linux-gpio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The new pinctrl driver selects GPIO_MLXBF3, but that can not be enabled yet because
the MELLANOX_PLATFORM symbol does not exist in the tree:
WARNING: unmet direct dependencies detected for GPIO_MLXBF3
Depends on [n]: GPIOLIB [=y] && PCI [=n] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
Selected by [y]:
- PINCTRL_MLXBF3 [=y] && PINCTRL [=y] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
As it turns out, the pinctlr driver still builds fine without this, so just
remove the select statement.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 77ff9a641aebf..57d57af1f624e 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -510,7 +510,6 @@ config PINCTRL_MLXBF3
select PINMUX
select GPIOLIB
select GPIOLIB_IRQCHIP
- select GPIO_MLXBF3
help
Say Y to select the pinctrl driver for BlueField-3 SoCs.
This pin controller allows selecting the mux function for
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: mlxbf3: remove broken Kconfig 'select'
2023-06-19 8:20 [PATCH] pinctrl: mlxbf3: remove broken Kconfig 'select' Arnd Bergmann
@ 2023-06-19 8:51 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-06-19 8:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Arnd Bergmann, Andy Shevchenko, Colin Foster, Lee Jones,
Lakshmi Sowjanya D, linux-gpio, linux-kernel
On Mon, Jun 19, 2023 at 10:21 AM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new pinctrl driver selects GPIO_MLXBF3, but that can not be enabled yet because
> the MELLANOX_PLATFORM symbol does not exist in the tree:
>
> WARNING: unmet direct dependencies detected for GPIO_MLXBF3
> Depends on [n]: GPIOLIB [=y] && PCI [=n] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
> Selected by [y]:
> - PINCTRL_MLXBF3 [=y] && PINCTRL [=y] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
>
> As it turns out, the pinctlr driver still builds fine without this, so just
> remove the select statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-19 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19 8:20 [PATCH] pinctrl: mlxbf3: remove broken Kconfig 'select' Arnd Bergmann
2023-06-19 8:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).