[libgpiod][PATCH 0/2] minor build warning fixes

[libgpiod][PATCH 0/2] minor build warning fixes

[Kent Gibson]

Fixes for a couple of minor warnings reported when building with a fresh
OS install.
The first fixes another typo in the examples makefile.
The second fixes another warning that is emitted by recent rust.

I note that with a fresh/minimal OS install the rust bindings still fail
to build due to a missing dependency on libclang and clang headers, but
that isn't tested for by configure - it fails during the build.

Kent Gibson (2):
  examples: fix typo in Makefile.am
  bindings: rust: fix unclear resolver warning

 bindings/rust/Cargo.toml | 2 ++
 examples/Makefile.am     | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.41.0

[libgpiod][PATCH 1/2] examples: fix typo in Makefile.am

[Kent Gibson]

The trailing "s" is missing from "toggle_multiple_line_values" in
several places, so add it.

Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
 examples/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/Makefile.am b/examples/Makefile.am
index daf902b..e92f303 100644
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -37,7 +37,7 @@ reconfigure_input_to_output_SOURCES = reconfigure_input_to_output.c
 
 toggle_line_value_SOURCES = toggle_line_value.c
 
-toggle_multiple_line_value_SOURCES = toggle_multiple_line_value.c
+toggle_multiple_line_values_SOURCES = toggle_multiple_line_values.c
 
 watch_line_info_SOURCES = watch_line_info.c
 
-- 
2.41.0

Re: [libgpiod][PATCH 1/2] examples: fix typo in Makefile.am

[Bartosz Golaszewski]

On Thu, Jun 29, 2023 at 12:15 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> The trailing "s" is missing from "toggle_multiple_line_values" in
> several places, so add it.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
>  examples/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/Makefile.am b/examples/Makefile.am
> index daf902b..e92f303 100644
> --- a/examples/Makefile.am
> +++ b/examples/Makefile.am
> @@ -37,7 +37,7 @@ reconfigure_input_to_output_SOURCES = reconfigure_input_to_output.c
>
>  toggle_line_value_SOURCES = toggle_line_value.c
>
> -toggle_multiple_line_value_SOURCES = toggle_multiple_line_value.c
> +toggle_multiple_line_values_SOURCES = toggle_multiple_line_values.c
>
>  watch_line_info_SOURCES = watch_line_info.c
>
> --
> 2.41.0
>

I'm wondering if we should just drop these as autotools will default
to using a single source file named after the target executable if
foobar_SOURCES is not defined. (iow: if the target is foobar and no
foobar_SOURCES is defined, then it will try foobar.c).

Bart

[libgpiod][PATCH 2/2] bindings: rust: fix unclear resolver warning

[Kent Gibson]

Fix the following warning:

"some crates are on edition 2021 which defaults to `resolver = "2"`,
 but virtual workspaces default to `resolver = "1"`"

Clarify the resolver selection as the 2021 edition by setting the
workspace.resolver to "2".

Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
 bindings/rust/Cargo.toml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/bindings/rust/Cargo.toml b/bindings/rust/Cargo.toml
index 2e026b4..e385027 100644
--- a/bindings/rust/Cargo.toml
+++ b/bindings/rust/Cargo.toml
@@ -9,3 +9,5 @@ members = [
     "libgpiod",
     "libgpiod-sys"
 ]
+
+resolver = "2"
-- 
2.41.0

Re: [libgpiod][PATCH 2/2] bindings: rust: fix unclear resolver warning

[Erik Schilling]

On Thu Jun 29, 2023 at 12:14 PM CEST, Kent Gibson wrote:
> Fix the following warning:
>
> "some crates are on edition 2021 which defaults to `resolver = "2"`,
>  but virtual workspaces default to `resolver = "1"`"
>
> Clarify the resolver selection as the 2021 edition by setting the
> workspace.resolver to "2".

Reviewed-by: Erik Schilling <erik.schilling@linaro.org>

Re: [libgpiod][PATCH 2/2] bindings: rust: fix unclear resolver warning

[Bartosz Golaszewski]

On Thu, Jun 29, 2023 at 12:15 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> Fix the following warning:
>
> "some crates are on edition 2021 which defaults to `resolver = "2"`,
>  but virtual workspaces default to `resolver = "1"`"
>
> Clarify the resolver selection as the 2021 edition by setting the
> workspace.resolver to "2".
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
>  bindings/rust/Cargo.toml | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/bindings/rust/Cargo.toml b/bindings/rust/Cargo.toml
> index 2e026b4..e385027 100644
> --- a/bindings/rust/Cargo.toml
> +++ b/bindings/rust/Cargo.toml
> @@ -9,3 +9,5 @@ members = [
>      "libgpiod",
>      "libgpiod-sys"
>  ]
> +
> +resolver = "2"
> --
> 2.41.0
>

Applied, thanks!

Bart