linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erik Schilling <erik.schilling@linaro.org>
To: Linux-GPIO <linux-gpio@vger.kernel.org>
Cc: Kent Gibson <warthog618@gmail.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Erik Schilling <erik.schilling@linaro.org>
Subject: [libgpiod][PATCH v2 0/4] bindings: rust: clippy: fix warnings
Date: Fri, 30 Jun 2023 13:18:43 +0200	[thread overview]
Message-ID: <20230630-clippy-v2-0-f44447925ad6@linaro.org> (raw)

This follows up on my promise on Kent's series [1] to look into whether
these casts are needed or not. Most are not, a few are false-positives.

I also explored some shunit2 based test-script to automate the testing,
but that became ugly with linking issue and needs me to revisit it
another time. So this only sends the clippy fixes for now.

Tested the build (lib + examples + test) and clippy report on:
- Fedora 38 x86_64
- Fedora 38 aarch64
- Debian 12 armv7hf

Test execution (cargo test) was tested on:
- Fedora 38 x86_64
- Fedora 38 aarch64

Could not execute tests on armv7hf due to lack of suitable test
environment.

[1] https://lore.kernel.org/r/20230612154055.56556-1-warthog618@gmail.com

To: Linux-GPIO <linux-gpio@vger.kernel.org>
Cc: Kent Gibson <warthog618@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>

Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
---
Changes in v2:
- Changed cover letter title to active language
- Improved commit messages (hopefully)
- Elaborated what was built and tested
- Resent with hacked b4 for proper [libgpiod] tag
- Link to v1: https://lore.kernel.org/r/20230629-clippy-v1-0-9ff088713c54@linaro.org

---
Erik Schilling (4):
      bindings: rust: clippy: drop unnecessary casts
      bindings: rust: clippy: silence false-positives on casts
      bindings: rust: clippy: drop unneeded conversions
      bindings: rust: clippy: silence false-positive on iterator

 bindings/rust/gpiosim-sys/src/lib.rs         | 2 +-
 bindings/rust/gpiosim-sys/src/sim.rs         | 4 ++--
 bindings/rust/libgpiod/src/chip.rs           | 2 +-
 bindings/rust/libgpiod/src/edge_event.rs     | 2 +-
 bindings/rust/libgpiod/src/event_buffer.rs   | 7 +++++--
 bindings/rust/libgpiod/src/info_event.rs     | 2 +-
 bindings/rust/libgpiod/src/lib.rs            | 2 +-
 bindings/rust/libgpiod/src/line_config.rs    | 4 ++--
 bindings/rust/libgpiod/src/line_info.rs      | 3 +++
 bindings/rust/libgpiod/src/line_request.rs   | 8 ++++----
 bindings/rust/libgpiod/src/line_settings.rs  | 5 ++++-
 bindings/rust/libgpiod/src/request_config.rs | 2 +-
 bindings/rust/libgpiod/tests/chip.rs         | 2 +-
 13 files changed, 27 insertions(+), 18 deletions(-)
---
base-commit: 4510231c95a087f58a155cf74164e403e1e0584f
change-id: 20230629-clippy-890c541c6d09

Best regards,
-- 
Erik Schilling <erik.schilling@linaro.org>


             reply	other threads:[~2023-06-30 11:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30 11:18 Erik Schilling [this message]
2023-06-30 11:18 ` [libgpiod][PATCH v2 1/4] bindings: rust: clippy: drop unnecessary casts Erik Schilling
2023-06-30 11:18 ` [libgpiod][PATCH v2 2/4] bindings: rust: clippy: silence false-positives on casts Erik Schilling
2023-06-30 11:18 ` [libgpiod][PATCH v2 3/4] bindings: rust: clippy: drop unneeded conversions Erik Schilling
2023-06-30 11:18 ` [libgpiod][PATCH v2 4/4] bindings: rust: clippy: silence false-positive on iterator Erik Schilling
2023-06-30 11:54 ` [libgpiod][PATCH v2 0/4] bindings: rust: clippy: fix warnings Kent Gibson
2023-06-30 12:15 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230630-clippy-v2-0-f44447925ad6@linaro.org \
    --to=erik.schilling@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).