From: Erik Schilling <erik.schilling@linaro.org>
To: Linux-GPIO <linux-gpio@vger.kernel.org>
Cc: Kent Gibson <warthog618@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Erik Schilling <erik.schilling@linaro.org>
Subject: [libgpiod][PATCH v2 4/4] bindings: rust: clippy: silence false-positive on iterator
Date: Fri, 30 Jun 2023 13:18:47 +0200 [thread overview]
Message-ID: <20230630-clippy-v2-4-f44447925ad6@linaro.org> (raw)
In-Reply-To: <20230630-clippy-v2-0-f44447925ad6@linaro.org>
This was fixed on clippy master [1], but it is still broken on 0.1.70. So
lets silence it until the clippy fix is widely available.
clippy version: clippy 0.1.70 (90c5418 2023-05-31).
[1] https://github.com/rust-lang/rust-clippy/commit/9fa40894103e32364fdbade539d4ecb3d40f3d7f
Reported-by: Kent Gibson <warthog618@gmail.com>
Link: https://lore.kernel.org/r/20230612154055.56556-1-warthog618@gmail.com
Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
---
bindings/rust/libgpiod/src/event_buffer.rs | 3 +++
1 file changed, 3 insertions(+)
diff --git a/bindings/rust/libgpiod/src/event_buffer.rs b/bindings/rust/libgpiod/src/event_buffer.rs
index b79e9ea..2e4bfd3 100644
--- a/bindings/rust/libgpiod/src/event_buffer.rs
+++ b/bindings/rust/libgpiod/src/event_buffer.rs
@@ -54,6 +54,9 @@ impl<'a> Iterator for Events<'a> {
}
fn next(&mut self) -> Option<Self::Item> {
+ // clippy false-positive, fixed in next clippy release:
+ // https://github.com/rust-lang/rust-clippy/issues/9820
+ #[allow(clippy::iter_nth_zero)]
self.nth(0)
}
}
--
2.41.0
next prev parent reply other threads:[~2023-06-30 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 11:18 [libgpiod][PATCH v2 0/4] bindings: rust: clippy: fix warnings Erik Schilling
2023-06-30 11:18 ` [libgpiod][PATCH v2 1/4] bindings: rust: clippy: drop unnecessary casts Erik Schilling
2023-06-30 11:18 ` [libgpiod][PATCH v2 2/4] bindings: rust: clippy: silence false-positives on casts Erik Schilling
2023-06-30 11:18 ` [libgpiod][PATCH v2 3/4] bindings: rust: clippy: drop unneeded conversions Erik Schilling
2023-06-30 11:18 ` Erik Schilling [this message]
2023-06-30 11:54 ` [libgpiod][PATCH v2 0/4] bindings: rust: clippy: fix warnings Kent Gibson
2023-06-30 12:15 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630-clippy-v2-4-f44447925ad6@linaro.org \
--to=erik.schilling@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).