From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [libgpiod][PATCH] build: remove redundant SOURCES assignments
Date: Fri, 30 Jun 2023 14:28:25 +0200 [thread overview]
Message-ID: <20230630122825.117902-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
For any given target (let's say foobar), automake defaults to looking for
foobar.c if foobar_SOURCES are not specified. Remove redundant assignments
as we've seen multiple hidden typos in makefiles already.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
examples/Makefile.am | 26 --------------------------
tests/gpiosim/Makefile.am | 1 -
tools/Makefile.am | 12 ------------
3 files changed, 39 deletions(-)
diff --git a/examples/Makefile.am b/examples/Makefile.am
index daf902b..ed01dbc 100644
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -20,29 +20,3 @@ noinst_PROGRAMS = \
watch_line_rising \
watch_line_value \
watch_multiple_line_values
-
-async_watch_line_value_SOURCES = async_watch_line_value.c
-
-find_line_by_name_SOURCES = find_line_by_name.c
-
-get_chip_info_SOURCES = get_chip_info.c
-
-get_line_info_SOURCES = get_line_info.c
-
-get_line_value_SOURCES = get_line_value.c
-
-get_multiple_line_values_SOURCES = get_multiple_line_values.c
-
-reconfigure_input_to_output_SOURCES = reconfigure_input_to_output.c
-
-toggle_line_value_SOURCES = toggle_line_value.c
-
-toggle_multiple_line_value_SOURCES = toggle_multiple_line_value.c
-
-watch_line_info_SOURCES = watch_line_info.c
-
-watch_line_rising_SOURCES = watch_line_rising.c
-
-watch_line_value_SOURCES = watch_line_value.c
-
-watch_multiple_line_values_SOURCES = watch_multiple_line_values.c
diff --git a/tests/gpiosim/Makefile.am b/tests/gpiosim/Makefile.am
index 05dce79..5888873 100644
--- a/tests/gpiosim/Makefile.am
+++ b/tests/gpiosim/Makefile.am
@@ -12,5 +12,4 @@ libgpiosim_la_CFLAGS = $(AM_CFLAGS) $(KMOD_CFLAGS) $(MOUNT_CFLAGS)
libgpiosim_la_LDFLAGS = -version-info $(subst .,:,$(ABI_GPIOSIM_VERSION))
libgpiosim_la_LDFLAGS += $(KMOD_LIBS) $(MOUNT_LIBS) -pthread
-gpiosim_selftest_SOURCES = gpiosim-selftest.c
gpiosim_selftest_LDADD = libgpiosim.la
diff --git a/tools/Makefile.am b/tools/Makefile.am
index 92a819f..40ea3a3 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -18,18 +18,6 @@ endif
bin_PROGRAMS = gpiodetect gpioinfo gpioget gpioset gpiomon gpionotify
-gpiodetect_SOURCES = gpiodetect.c
-
-gpioinfo_SOURCES = gpioinfo.c
-
-gpioget_SOURCES = gpioget.c
-
-gpioset_SOURCES = gpioset.c
-
-gpiomon_SOURCES = gpiomon.c
-
-gpionotify_SOURCES = gpionotify.c
-
if WITH_TESTS
noinst_SCRIPTS = gpio-tools-test.bash
--
2.39.2
next reply other threads:[~2023-06-30 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 12:28 Bartosz Golaszewski [this message]
2023-06-30 12:31 ` [libgpiod][PATCH] build: remove redundant SOURCES assignments Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630122825.117902-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).