From: Rob Herring <robh@kernel.org>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"Verdun, Jean-Marie" <verdun@hpe.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"brgl@bgdev.pl" <brgl@bgdev.pl>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v5 1/5] dt-bindings: gpio: Add HPE GXP GPIO
Date: Thu, 6 Jul 2023 13:05:23 -0600 [thread overview]
Message-ID: <20230706190523.GA155073-robh@kernel.org> (raw)
In-Reply-To: <31F41D4F-D386-48B5-B941-D5B7C691280A@hpe.com>
On Thu, Jul 06, 2023 at 02:12:12PM +0000, Hawkins, Nick wrote:
> Greetings Krzysztof,
>
> Thank you for the feedback. I see that due to a patch conflict I
> reintroduced some of the alignment issues you had me fix in
> a previous version. This was a mistake and I will correct this.
>
> > > v5:
> > > *Removed use of gpio-gxp in favor of just supporting
> > > hpe,gxp-gpio-pl for now as the full gpio-gxp will
> > > require a much larger patchset
>
> > Bindings describe hardware, not drivers, and should be rather complete.
>
> This patch is intended to still cover the hardware interface between our
> BMC and our CPLD which gathers GPIO for us. The part of the binding I
> removed was a completely separate interface with different mechanisms
> for reading GPIOs. With that said I could keep these two interfaces
> separate in yaml files: Having a yaml for hpe,gxp-gpio and another for
> hpe,gxp-gpio-pl. Would this be a better approach?
If they are independent (and it sounds like they are), then yes.
Rob
next prev parent reply other threads:[~2023-07-06 19:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 19:45 [PATCH v5 0/5] ARM: Add GPIO support nick.hawkins
2023-07-05 19:45 ` [PATCH v5 1/5] dt-bindings: gpio: Add HPE GXP GPIO nick.hawkins
2023-07-06 6:22 ` Krzysztof Kozlowski
2023-07-06 14:12 ` Hawkins, Nick
2023-07-06 19:05 ` Rob Herring [this message]
2023-07-05 19:45 ` [PATCH v5 2/5] gpio: gxp: Add HPE GXP GPIO PL nick.hawkins
2023-07-20 15:12 ` Bartosz Golaszewski
2023-07-20 20:26 ` Hawkins, Nick
2023-07-05 19:45 ` [PATCH v5 3/5] dt-bindings: hwmon: hpe,gxp-fan-ctrl: remove fn2 and pl registers nick.hawkins
2023-07-05 19:45 ` [PATCH v5 4/5] hwmon: (gxp_fan_ctrl) Provide fan info via gpio nick.hawkins
2023-07-05 19:45 ` [PATCH v5 5/5] MAINTAINERS: hpe: Add GPIO nick.hawkins
2023-07-16 21:12 ` [PATCH v5 0/5] ARM: Add GPIO support Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706190523.GA155073-robh@kernel.org \
--to=robh@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nick.hawkins@hpe.com \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).