From: Conor Dooley <conor@kernel.org>
To: Huqiang Qin <huqiang.qin@amlogic.com>
Cc: linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
brgl@bgdev.pl, andy@kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] dt-bindings: gpio: Add a header file for Amlogic C3 SoCs
Date: Mon, 10 Jul 2023 17:38:23 +0100 [thread overview]
Message-ID: <20230710-maybe-mantis-e647d94fd13a@spud> (raw)
In-Reply-To: <20230710042812.2007928-2-huqiang.qin@amlogic.com>
[-- Attachment #1: Type: text/plain, Size: 3133 bytes --]
On Mon, Jul 10, 2023 at 12:28:11PM +0800, Huqiang Qin wrote:
> Add dt-binding and related header file for Amlogic C3 GPIO.
>
> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
> ---
> .../pinctrl/amlogic,meson-pinctrl-a1.yaml | 1 +
> include/dt-bindings/gpio/amlogic-c3-gpio.h | 72 +++++++++++++++++++
> 2 files changed, 73 insertions(+)
> create mode 100644 include/dt-bindings/gpio/amlogic-c3-gpio.h
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml
> index 99080c9eaac3..e019b6aa6ca3 100644
> --- a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml
> @@ -17,6 +17,7 @@ properties:
> enum:
> - amlogic,meson-a1-periphs-pinctrl
> - amlogic,meson-s4-periphs-pinctrl
> + - amlogic,c3-periphs-pinctrl
Alphanumerical order here perhaps?
> required:
> - compatible
> diff --git a/include/dt-bindings/gpio/amlogic-c3-gpio.h b/include/dt-bindings/gpio/amlogic-c3-gpio.h
> new file mode 100644
> index 000000000000..75c8da6f505f
> --- /dev/null
> +++ b/include/dt-bindings/gpio/amlogic-c3-gpio.h
> @@ -0,0 +1,72 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
Any reason to deviate from the usual license terms for bindings, which is
"GPL-2.0-only OR BSD-2-Clause"?
Cheers,
Conor.
> +/*
> + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
> + * Author: Huqiang Qin <huqiang.qin@amlogic.com>
> + */
> +
> +#ifndef _DT_BINDINGS_AMLOGIC_C3_GPIO_H
> +#define _DT_BINDINGS_AMLOGIC_C3_GPIO_H
> +
> +#define GPIOE_0 0
> +#define GPIOE_1 1
> +#define GPIOE_2 2
> +#define GPIOE_3 3
> +#define GPIOE_4 4
> +
> +#define GPIOB_0 5
> +#define GPIOB_1 6
> +#define GPIOB_2 7
> +#define GPIOB_3 8
> +#define GPIOB_4 9
> +#define GPIOB_5 10
> +#define GPIOB_6 11
> +#define GPIOB_7 12
> +#define GPIOB_8 13
> +#define GPIOB_9 14
> +#define GPIOB_10 15
> +#define GPIOB_11 16
> +#define GPIOB_12 17
> +#define GPIOB_13 18
> +#define GPIOB_14 19
> +
> +#define GPIOC_0 20
> +#define GPIOC_1 21
> +#define GPIOC_2 22
> +#define GPIOC_3 23
> +#define GPIOC_4 24
> +#define GPIOC_5 25
> +#define GPIOC_6 26
> +
> +#define GPIOX_0 27
> +#define GPIOX_1 28
> +#define GPIOX_2 29
> +#define GPIOX_3 30
> +#define GPIOX_4 31
> +#define GPIOX_5 32
> +#define GPIOX_6 33
> +#define GPIOX_7 34
> +#define GPIOX_8 35
> +#define GPIOX_9 36
> +#define GPIOX_10 37
> +#define GPIOX_11 38
> +#define GPIOX_12 39
> +#define GPIOX_13 40
> +
> +#define GPIOD_0 41
> +#define GPIOD_1 42
> +#define GPIOD_2 43
> +#define GPIOD_3 44
> +#define GPIOD_4 45
> +#define GPIOD_5 46
> +#define GPIOD_6 47
> +
> +#define GPIOA_0 48
> +#define GPIOA_1 49
> +#define GPIOA_2 50
> +#define GPIOA_3 51
> +#define GPIOA_4 52
> +#define GPIOA_5 53
> +
> +#define GPIO_TEST_N 54
> +
> +#endif /* _DT_BINDINGS_AMLOGIC_C3_GPIO_H */
> --
> 2.37.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-07-10 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 4:28 [PATCH V2 0/2] Add pinctrl driver support for Amlogic C3 SoCs Huqiang Qin
2023-07-10 4:28 ` [PATCH V2 1/2] dt-bindings: gpio: Add a header file " Huqiang Qin
2023-07-10 9:04 ` Bartosz Golaszewski
2023-07-10 16:38 ` Conor Dooley [this message]
2023-07-11 2:55 ` Huqiang Qin
2023-07-11 18:05 ` Conor Dooley
2023-07-12 5:56 ` Krzysztof Kozlowski
2023-07-14 8:43 ` Kelvin Zhang
2023-07-10 4:28 ` [PATCH V2 2/2] pinctrl: Add driver support " Huqiang Qin
2023-07-10 7:33 ` Andy Shevchenko
2023-07-10 9:32 ` Huqiang Qin
2023-07-10 7:26 ` [PATCH V2 0/2] Add pinctrl " Andy Shevchenko
2023-07-10 8:03 ` Huqiang Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710-maybe-mantis-e647d94fd13a@spud \
--to=conor@kernel.org \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).