* [PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call
@ 2023-07-17 12:55 Andrei Coardos
2023-07-17 14:17 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Coardos @ 2023-07-17 12:55 UTC (permalink / raw)
To: linux-gpio, linux-kernel
Cc: florian.fainelli, andy, linus.walleij, sbranden, brgl,
Andrei Coardos, Alexandru Ardelean
The platform_set_drvdata() call was never used, ever since the driver was
originally added.
It looks like this copy+paste left-over. Possibly the author copied from a
driver that had this line, but also had a remove hook.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/gpio/gpio-bcm-kona.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index 70770429ba48..2e50a07a43e6 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -597,7 +597,6 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
return -ENOMEM;
kona_gpio->pdev = pdev;
- platform_set_drvdata(pdev, kona_gpio);
chip->parent = dev;
chip->ngpio = kona_gpio->num_bank * GPIO_PER_BANK;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call
2023-07-17 12:55 [PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call Andrei Coardos
@ 2023-07-17 14:17 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2023-07-17 14:17 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-gpio, linux-kernel, florian.fainelli, linus.walleij,
sbranden, brgl, Alexandru Ardelean
On Mon, Jul 17, 2023 at 03:55:21PM +0300, Andrei Coardos wrote:
> The platform_set_drvdata() call was never used, ever since the driver was
> originally added.
> It looks like this copy+paste left-over. Possibly the author copied from a
> driver that had this line, but also had a remove hook.
Cool, I'll incorporate this into my series. I'll make it as v2 to avoid clashes
with this one.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-17 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 12:55 [PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-17 14:17 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).