* [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call
@ 2023-07-19 9:48 Andrei Coardos
2023-07-19 15:30 ` Andy Shevchenko
2023-07-29 14:06 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Andrei Coardos @ 2023-07-19 9:48 UTC (permalink / raw)
To: linux-kernel, linux-gpio
Cc: andy, brgl, linus.walleij, Andrei Coardos, Alexandru Ardelean
The platform_set_drvdata() isn't needed for anything. The function is a
simple setter that doesn't change anything in the code. That is because
there isn't a get function and since it has no dependencies it can be
removed.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/gpio/gpio-logicvc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-logicvc.c b/drivers/gpio/gpio-logicvc.c
index 992cc958a43f..9b4789deae45 100644
--- a/drivers/gpio/gpio-logicvc.c
+++ b/drivers/gpio/gpio-logicvc.c
@@ -139,8 +139,6 @@ static int logicvc_gpio_probe(struct platform_device *pdev)
logicvc->chip.set = logicvc_gpio_set;
logicvc->chip.direction_output = logicvc_gpio_direction_output;
- platform_set_drvdata(pdev, logicvc);
-
return devm_gpiochip_add_data(dev, &logicvc->chip, logicvc);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call
2023-07-19 9:48 [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call Andrei Coardos
@ 2023-07-19 15:30 ` Andy Shevchenko
2023-07-29 14:06 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-07-19 15:30 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-gpio, brgl, linus.walleij, Alexandru Ardelean
On Wed, Jul 19, 2023 at 12:48:03PM +0300, Andrei Coardos wrote:
> The platform_set_drvdata() isn't needed for anything. The function is a
> simple setter that doesn't change anything in the code. That is because
> there isn't a get function and since it has no dependencies it can be
> removed.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call
2023-07-19 9:48 [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-19 15:30 ` Andy Shevchenko
@ 2023-07-29 14:06 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-07-29 14:06 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-gpio, andy, linus.walleij, Alexandru Ardelean
On Wed, Jul 19, 2023 at 11:48 AM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> The platform_set_drvdata() isn't needed for anything. The function is a
> simple setter that doesn't change anything in the code. That is because
> there isn't a get function and since it has no dependencies it can be
> removed.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/gpio/gpio-logicvc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-logicvc.c b/drivers/gpio/gpio-logicvc.c
> index 992cc958a43f..9b4789deae45 100644
> --- a/drivers/gpio/gpio-logicvc.c
> +++ b/drivers/gpio/gpio-logicvc.c
> @@ -139,8 +139,6 @@ static int logicvc_gpio_probe(struct platform_device *pdev)
> logicvc->chip.set = logicvc_gpio_set;
> logicvc->chip.direction_output = logicvc_gpio_direction_output;
>
> - platform_set_drvdata(pdev, logicvc);
> -
> return devm_gpiochip_add_data(dev, &logicvc->chip, logicvc);
> }
>
> --
> 2.34.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-29 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-19 9:48 [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-19 15:30 ` Andy Shevchenko
2023-07-29 14:06 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).