* [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call
@ 2023-07-20 9:54 Andrei Coardos
2023-07-21 10:26 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andrei Coardos @ 2023-07-20 9:54 UTC (permalink / raw)
To: linux-kernel, linux-gpio
Cc: andy, brgl, linus.walleij, Andrei Coardos, Alexandru Ardelean
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call, to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/gpio/gpio-lp3943.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
index 79edd5db49d2..8e58242f5123 100644
--- a/drivers/gpio/gpio-lp3943.c
+++ b/drivers/gpio/gpio-lp3943.c
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
lp3943_gpio->chip = lp3943_gpio_chip;
lp3943_gpio->chip.parent = &pdev->dev;
- platform_set_drvdata(pdev, lp3943_gpio);
-
return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
lp3943_gpio);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call
2023-07-20 9:54 [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call Andrei Coardos
@ 2023-07-21 10:26 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-07-21 10:26 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-gpio, brgl, linus.walleij, Alexandru Ardelean
On Thu, Jul 20, 2023 at 12:54:55PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call, to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.
Is this a duplicate of previously sent the same?
Please, do correct versioning of the patches and changelogs being added.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call
@ 2023-07-20 13:29 Andrei Coardos
2023-07-20 16:07 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andrei Coardos @ 2023-07-20 13:29 UTC (permalink / raw)
To: linux-kernel, linux-gpio
Cc: andy, brgl, linus.walleij, Andrei Coardos, Alexandru Ardelean
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call, to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/gpio/gpio-lp3943.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
index 79edd5db49d2..8e58242f5123 100644
--- a/drivers/gpio/gpio-lp3943.c
+++ b/drivers/gpio/gpio-lp3943.c
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
lp3943_gpio->chip = lp3943_gpio_chip;
lp3943_gpio->chip.parent = &pdev->dev;
- platform_set_drvdata(pdev, lp3943_gpio);
-
return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
lp3943_gpio);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call
2023-07-20 13:29 Andrei Coardos
@ 2023-07-20 16:07 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-07-20 16:07 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-gpio, andy, brgl, linus.walleij,
Alexandru Ardelean
On Thu, Jul 20, 2023 at 4:29 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call, to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.
I got this twice, moreover the Subject is broken.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-21 10:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-20 9:54 [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-21 10:26 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2023-07-20 13:29 Andrei Coardos
2023-07-20 16:07 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).