From: Andrei Coardos <aboutphysycs@gmail.com>
To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: andy@kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org,
Andrei Coardos <aboutphysycs@gmail.com>,
Alexandru Ardelean <alex@shruggie.ro>
Subject: [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call
Date: Thu, 20 Jul 2023 16:29:11 +0300 [thread overview]
Message-ID: <20230720132911.23449-1-aboutphysycs@gmail.com> (raw)
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call, to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/gpio/gpio-lp3943.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
index 79edd5db49d2..8e58242f5123 100644
--- a/drivers/gpio/gpio-lp3943.c
+++ b/drivers/gpio/gpio-lp3943.c
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
lp3943_gpio->chip = lp3943_gpio_chip;
lp3943_gpio->chip.parent = &pdev->dev;
- platform_set_drvdata(pdev, lp3943_gpio);
-
return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
lp3943_gpio);
}
--
2.34.1
next reply other threads:[~2023-07-20 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 13:29 Andrei Coardos [this message]
2023-07-20 16:07 ` [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2023-07-20 9:54 Andrei Coardos
2023-07-21 10:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720132911.23449-1-aboutphysycs@gmail.com \
--to=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).