From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Erik Schilling <erik.schilling@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [libgpiod][PATCH v2 0/5] core: provide information about the parent chip in line requests
Date: Thu, 20 Jul 2023 16:47:42 +0200 [thread overview]
Message-ID: <20230720144747.73276-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
While working on the DBus API, it occurred to me that while we can obtain
the list of requested offsets from a line request, this information lacks
context if we cannot get any information about the parent chip on which
the request was made.
We cannot reference the chip in any way as its lifetime is disconnected
from the request but we can at least provide the name of the chip used
to create the request providing some context for the offsets.
This series adds a new getter for struct gpiod_line_request and wrappers
for it for all bindings. This will be used in the upcoming DBus GPIO
manager code.
v1 -> v2:
- provide the chip name, not its filesystem path
- fix UNSAFE comments in rust bindings
Bartosz Golaszewski (5):
core: provide gpiod_line_request_get_chip_name()
tests: add a test-case for gpiod_line_request_get_chip_name()
bindings: cxx: provide line_request::chip_name()
bindings: python: provide the chip_name property in line_request
bindings: rust: provide LineRequest::chip_name()
bindings/cxx/gpiodcxx/line-request.hpp | 6 ++++++
bindings/cxx/line-request.cpp | 10 +++++++++-
bindings/cxx/tests/tests-line-request.cpp | 6 ++++--
bindings/python/gpiod/chip.py | 1 +
bindings/python/gpiod/ext/request.c | 11 ++++++++++
bindings/python/gpiod/line_request.py | 12 +++++++++--
bindings/python/tests/tests_line_request.py | 13 +++++++-----
bindings/rust/libgpiod/src/line_request.rs | 16 +++++++++++++++
bindings/rust/libgpiod/tests/line_request.rs | 14 +++++++++++++
include/gpiod.h | 9 +++++++++
lib/chip.c | 7 ++++++-
lib/internal.h | 3 ++-
lib/line-request.c | 20 ++++++++++++++++++-
tests/tests-line-request.c | 21 ++++++++++++++++++++
14 files changed, 136 insertions(+), 13 deletions(-)
--
2.39.2
next reply other threads:[~2023-07-20 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 14:47 Bartosz Golaszewski [this message]
2023-07-20 14:47 ` [libgpiod][PATCH v2 1/5] core: provide gpiod_line_request_get_chip_name() Bartosz Golaszewski
2023-07-20 14:47 ` [libgpiod][PATCH v2 2/5] tests: add a test-case for gpiod_line_request_get_chip_name() Bartosz Golaszewski
2023-07-20 14:47 ` [libgpiod][PATCH v2 3/5] bindings: cxx: provide line_request::chip_name() Bartosz Golaszewski
2023-07-20 14:47 ` [libgpiod][PATCH v2 4/5] bindings: python: provide the chip_name property in line_request Bartosz Golaszewski
2023-07-20 14:47 ` [libgpiod][PATCH v2 5/5] bindings: rust: provide LineRequest::chip_name() Bartosz Golaszewski
2023-07-20 14:53 ` Erik Schilling
2023-07-21 3:15 ` Kent Gibson
2023-07-21 18:35 ` Bartosz Golaszewski
2023-07-22 2:07 ` Kent Gibson
2023-07-22 12:30 ` Bartosz Golaszewski
2023-07-21 3:27 ` Kent Gibson
2023-07-21 6:55 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720144747.73276-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=erik.schilling@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).