* [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata()
@ 2023-07-21 13:08 Andrei Coardos
2023-07-21 15:10 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andrei Coardos @ 2023-07-21 13:08 UTC (permalink / raw)
To: linux-mediatek, linux-arm-kernel, linux-kernel, linux-gpio
Cc: angelogioacchino.delregno, matthias.bgg, andy, brgl,
linus.walleij, Andrei Coardos, Alexandru Ardelean
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/gpio/gpio-mt7621.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
index 93facbebb80e..c0c715167d9c 100644
--- a/drivers/gpio/gpio-mt7621.c
+++ b/drivers/gpio/gpio-mt7621.c
@@ -315,7 +315,6 @@ mediatek_gpio_probe(struct platform_device *pdev)
return mtk->gpio_irq;
mtk->dev = dev;
- platform_set_drvdata(pdev, mtk);
for (i = 0; i < MTK_BANK_CNT; i++) {
ret = mediatek_gpio_bank_probe(dev, i);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata()
2023-07-21 13:08 [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata() Andrei Coardos
@ 2023-07-21 15:10 ` Andy Shevchenko
2023-07-25 13:25 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2023-07-21 15:10 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-mediatek, linux-arm-kernel, linux-kernel, linux-gpio,
angelogioacchino.delregno, matthias.bgg, brgl, linus.walleij,
Alexandru Ardelean
On Fri, Jul 21, 2023 at 04:08:38PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata()
2023-07-21 15:10 ` Andy Shevchenko
@ 2023-07-25 13:25 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-07-25 13:25 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-mediatek, linux-arm-kernel, linux-kernel, linux-gpio,
angelogioacchino.delregno, matthias.bgg, brgl, linus.walleij,
Alexandru Ardelean
On Fri, Jul 21, 2023 at 06:10:32PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 21, 2023 at 04:08:38PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver.
Not true.
> > Also, the private data is defined in this driver, so there is no risk of
> > it being accessed outside of this driver file.
>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
I have to withdraw this, the patch is wrong.
NAK.
Sorry for the confusion (I have looked for the wrong pattern).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-25 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-21 13:08 [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata() Andrei Coardos
2023-07-21 15:10 ` Andy Shevchenko
2023-07-25 13:25 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).