From: Greg KH <gregkh@linuxfoundation.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Rob Herring <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jirislaby@kernel.org, jringle@gridpoint.com,
isaac.true@canonical.com, jesse.sung@canonical.com,
tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
stable@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Lech Perczak <lech.perczak@camlingroup.com>
Subject: Re: [RESEND PATCH v8 06/10] serial: sc16is7xx: fix regression with GPIO configuration
Date: Sat, 22 Jul 2023 17:15:26 +0200 [thread overview]
Message-ID: <2023072240-supremacy-shallot-a77f@gregkh> (raw)
In-Reply-To: <20230722104724.ef0c5896c239e721794b9fe9@hugovil.com>
On Sat, Jul 22, 2023 at 10:47:24AM -0400, Hugo Villeneuve wrote:
> On Fri, 21 Jul 2023 13:24:19 -0600
> Rob Herring <robh+dt@kernel.org> wrote:
>
> > On Fri, Jul 21, 2023 at 10:19 AM Hugo Villeneuve <hugo@hugovil.com> wrote:
> > >
> > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > >
> > > Commit 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines")
> > > and commit 21144bab4f11 ("sc16is7xx: Handle modem status lines")
> > > changed the function of the GPIOs pins to act as modem control
> > > lines without any possibility of selecting GPIO function.
> >
> > Requiring a new DT property is not fixing a kernel regression. You
> > should be returning the kernel to original behavior and then have a
> > new DT property for new behavior.
>
> Hi Rob,
> please read the entire patch history starting from V1
> and you will understand why this course of action was
> not selected.
That's not going to happen, sorry, you need to explain it here, in this
patch series, why a specific action is being taken over another one, as
no one has time to go dig through past history, sorry.
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-22 15:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 16:18 [RESEND PATCH v8 00/10] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 01/10] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 02/10] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 03/10] serial: sc16is7xx: remove obsolete out_thread label Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 04/10] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 05/10] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 06/10] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-07-21 19:24 ` Rob Herring
2023-07-22 14:47 ` Hugo Villeneuve
2023-07-22 15:15 ` Greg KH [this message]
2023-07-24 15:54 ` Hugo Villeneuve
2023-07-31 15:31 ` Rob Herring
2023-07-31 16:46 ` Hugo Villeneuve
2023-07-31 18:04 ` Rob Herring
2023-07-31 18:41 ` Hugo Villeneuve
2023-08-03 17:54 ` Hugo Villeneuve
2023-08-03 20:10 ` Rob Herring
2023-08-03 21:38 ` Hugo Villeneuve
2023-08-07 14:55 ` Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 07/10] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 08/10] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 09/10] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-07-21 16:18 ` [RESEND PATCH v8 10/10] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023072240-supremacy-shallot-a77f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=isaac.true@canonical.com \
--cc=jesse.sung@canonical.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=lech.perczak@camlingroup.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).