From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>
Subject: [PATCH v1 4/6] gpio: ge: Utilise temporary variable for struct device
Date: Mon, 24 Jul 2023 19:13:18 +0300 [thread overview]
Message-ID: <20230724161320.63876-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230724161320.63876-1-andriy.shevchenko@linux.intel.com>
We have a temporary variable to keep pointer to struct device.
Utilise it inside the ->probe() implementation.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-ge.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-ge.c b/drivers/gpio/gpio-ge.c
index d019669048e6..268de5496fcb 100644
--- a/drivers/gpio/gpio-ge.c
+++ b/drivers/gpio/gpio-ge.c
@@ -59,7 +59,7 @@ static int __init gef_gpio_probe(struct platform_device *pdev)
void __iomem *regs;
int ret;
- gc = devm_kzalloc(&pdev->dev, sizeof(*gc), GFP_KERNEL);
+ gc = devm_kzalloc(dev, sizeof(*gc), GFP_KERNEL);
if (!gc)
return -ENOMEM;
@@ -67,9 +67,9 @@ static int __init gef_gpio_probe(struct platform_device *pdev)
if (IS_ERR(regs))
return PTR_ERR(regs);
- ret = bgpio_init(gc, &pdev->dev, 4, regs + GEF_GPIO_IN,
- regs + GEF_GPIO_OUT, NULL, NULL,
- regs + GEF_GPIO_DIRECT, BGPIOF_BIG_ENDIAN_BYTE_ORDER);
+ ret = bgpio_init(gc, dev, 4, regs + GEF_GPIO_IN, regs + GEF_GPIO_OUT,
+ NULL, NULL, regs + GEF_GPIO_DIRECT,
+ BGPIOF_BIG_ENDIAN_BYTE_ORDER);
if (ret)
return dev_err_probe(dev, ret, "bgpio_init failed\n");
@@ -82,7 +82,7 @@ static int __init gef_gpio_probe(struct platform_device *pdev)
gc->ngpio = (uintptr_t)device_get_match_data(dev);
/* This function adds a memory mapped GPIO chip */
- ret = devm_gpiochip_add_data(&pdev->dev, gc, NULL);
+ ret = devm_gpiochip_add_data(dev, gc, NULL);
if (ret)
return dev_err_probe(dev, ret, "GPIO chip registration failed\n");
--
2.40.0.1.gaa8946217a0b
next prev parent reply other threads:[~2023-07-24 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 16:13 [PATCH v1 0/6] gpio: ge: fixes and cleanups Andy Shevchenko
2023-07-24 16:13 ` [PATCH v1 1/6] gpio: ge: Add missing header Andy Shevchenko
2023-07-26 18:05 ` Rob Herring
2023-07-24 16:13 ` [PATCH v1 2/6] gpio: ge: Fix English spelling and grammar Andy Shevchenko
2023-07-24 16:13 ` [PATCH v1 3/6] gpio: ge: Make driver OF-independent Andy Shevchenko
2023-07-24 16:13 ` Andy Shevchenko [this message]
2023-07-24 16:13 ` [PATCH v1 5/6] gpio: ge: Replace GPLv2 boilerplate with SPDX Andy Shevchenko
2023-07-24 16:13 ` [PATCH v1 6/6] gpio: ge: Enable COMPILE_TEST for the driver Andy Shevchenko
2023-07-24 22:55 ` [PATCH v1 0/6] gpio: ge: fixes and cleanups Randy Dunlap
2023-07-27 7:33 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724161320.63876-5-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).