From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, brgl@bgdev.pl
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [libgpiod][PATCH] examples: simplify find_line_by_name
Date: Fri, 28 Jul 2023 05:10:56 +0800 [thread overview]
Message-ID: <20230727211056.19187-1-warthog618@gmail.com> (raw)
Simplify the find_line_by_name example by using
gpiod_chip_get_line_offset_from_name() rather than iterating over each
line in a chip.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
examples/find_line_by_name.c | 31 +++++++++++--------------------
1 file changed, 11 insertions(+), 20 deletions(-)
diff --git a/examples/find_line_by_name.c b/examples/find_line_by_name.c
index 16d2c4c..87b66ac 100644
--- a/examples/find_line_by_name.c
+++ b/examples/find_line_by_name.c
@@ -69,12 +69,9 @@ int main(void)
static const char *const line_name = "GPIO19";
struct gpiod_chip_info *cinfo;
- struct gpiod_line_info *linfo;
- unsigned int j, num_lines;
struct gpiod_chip *chip;
char **chip_paths;
- const char *name;
- int i, num_chips;
+ int i, num_chips, offset;
/*
* Names are not guaranteed unique, so this finds the first line with
@@ -85,26 +82,20 @@ int main(void)
chip = gpiod_chip_open(chip_paths[i]);
if (!chip)
continue;
+
+ offset = gpiod_chip_get_line_offset_from_name(chip, line_name);
+ if (offset == -1)
+ goto close_chip;
+
cinfo = gpiod_chip_get_info(chip);
if (!cinfo)
- continue;
+ goto close_chip;
- num_lines = gpiod_chip_info_get_num_lines(cinfo);
- for (j = 0; j < num_lines; j++) {
- linfo = gpiod_chip_get_line_info(chip, j);
- if (!linfo)
- continue;
- name = gpiod_line_info_get_name(linfo);
- if (name && (strcmp(line_name, name) == 0)) {
- printf("%s: %s %d\n", line_name,
- gpiod_chip_info_get_name(cinfo), j);
- return EXIT_SUCCESS;
- }
-
- gpiod_line_info_free(linfo);
- }
+ printf("%s: %s %d\n", line_name,
+ gpiod_chip_info_get_name(cinfo), offset);
+ return EXIT_SUCCESS;
- gpiod_chip_info_free(cinfo);
+close_chip:
gpiod_chip_close(chip);
}
--
2.41.0
next reply other threads:[~2023-07-27 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 21:10 Kent Gibson [this message]
2023-07-28 15:00 ` [libgpiod][PATCH] examples: simplify find_line_by_name Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727211056.19187-1-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).