linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com,
	isaac.true@canonical.com, jesse.sung@canonical.com,
	l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	stable@vger.kernel.org,
	Lech Perczak <lech.perczak@camlingroup.com>
Subject: Re: [PATCH v9 02/10] serial: sc16is7xx: mark IOCONTROL register as volatile
Date: Mon, 31 Jul 2023 17:50:40 +0200	[thread overview]
Message-ID: <2023073108-footboard-chooser-d20e@gregkh> (raw)
In-Reply-To: <20230725142343.1724130-3-hugo@hugovil.com>

On Tue, Jul 25, 2023 at 10:23:34AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> Bit SRESET (3) is cleared when a reset operation is completed. Having
> the IOCONTROL register as non-volatile will always read SRESET as 1,
> which is incorrect.
> 
> Also, if IOCONTROL register is not a volatile register, the upcoming
> patch "serial: sc16is7xx: fix regression with GPIO configuration"
> doesn't work when setting some shared GPIO lines as modem control
> lines.
> 
> Therefore mark IOCONTROL register as a volatile register.
> 
> Cc: <stable@vger.kernel.org> # 6.1.x

Why 6.1.y?  What commit does this fix?

> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
> Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
> ---
>  drivers/tty/serial/sc16is7xx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 8ae2afc76a9b..306ae512b38a 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -488,6 +488,7 @@ static bool sc16is7xx_regmap_volatile(struct device *dev, unsigned int reg)
>  	case SC16IS7XX_TXLVL_REG:
>  	case SC16IS7XX_RXLVL_REG:
>  	case SC16IS7XX_IOSTATE_REG:
> +	case SC16IS7XX_IOCONTROL_REG:
>  		return true;
>  	default:
>  		break;

Is this the same as this change:
	https://lore.kernel.org/all/20230724034727.17335-1-hui.wang@canonical.com/

confused,

greg k-h

  reply	other threads:[~2023-07-31 15:50 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 14:23 [PATCH v9 00/10] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 01/10] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-07-31 15:52   ` Greg KH
2023-08-01 17:16     ` Hugo Villeneuve
2023-08-03  7:54       ` Greg KH
2023-08-03 13:04         ` Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 02/10] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-07-31 15:50   ` Greg KH [this message]
2023-07-31 16:22     ` Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 03/10] serial: sc16is7xx: remove obsolete out_thread label Hugo Villeneuve
2023-07-31 15:53   ` Greg KH
2023-08-01 17:29     ` Hugo Villeneuve
2023-08-03  7:55       ` Greg KH
2023-07-25 14:23 ` [PATCH v9 04/10] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-07-31 15:55   ` Greg KH
2023-08-03 16:14     ` Hugo Villeneuve
2023-08-04 13:14       ` Greg KH
2023-08-04 14:15         ` Hugo Villeneuve
2023-08-04 15:09           ` Greg KH
2023-08-07 14:57             ` Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 05/10] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 06/10] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-07-31 15:58   ` Greg KH
2023-08-03 14:18     ` Hugo Villeneuve
2023-08-03 21:04       ` Andy Shevchenko
2023-08-04  4:53         ` Greg KH
2023-07-25 14:23 ` [PATCH v9 07/10] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 08/10] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-07-31 15:59   ` Greg KH
2023-08-03 14:38     ` Hugo Villeneuve
2023-08-04 13:14       ` Greg KH
2023-07-25 14:23 ` [PATCH v9 09/10] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-07-31 15:57   ` Greg KH
2023-07-31 17:00     ` Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 10/10] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
2023-07-31 15:56   ` Greg KH
2023-08-03 13:28     ` Hugo Villeneuve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023073108-footboard-chooser-d20e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hugo@hugovil.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=isaac.true@canonical.com \
    --cc=jesse.sung@canonical.com \
    --cc=jirislaby@kernel.org \
    --cc=jringle@gridpoint.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=l.perczak@camlintechnologies.com \
    --cc=lech.perczak@camlingroup.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tomasz.mon@camlingroup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).