From: Greg KH <gregkh@linuxfoundation.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com,
isaac.true@canonical.com, jesse.sung@canonical.com,
l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Lech Perczak <lech.perczak@camlingroup.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v9 03/10] serial: sc16is7xx: remove obsolete out_thread label
Date: Mon, 31 Jul 2023 17:53:10 +0200 [thread overview]
Message-ID: <2023073135-puppy-reflected-700d@gregkh> (raw)
In-Reply-To: <20230725142343.1724130-4-hugo@hugovil.com>
On Tue, Jul 25, 2023 at 10:23:35AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Commit c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later
> in probe") moved GPIO setup code later in probe function. Doing so
> also required to move ports cleanup code (out_ports label) after the
> GPIO cleanup code.
>
> After these moves, the out_thread label becomes misplaced and makes
> part of the cleanup code illogical.
>
> This patch remove the now obsolete out_thread label and make GPIO
> setup code jump to out_ports label if it fails.
>
> Fixes: c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later in probe")
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
> Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Why is this not ok for stable kernels yet it has a Fixes: tag?
Please fix.
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-31 15:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 14:23 [PATCH v9 00/10] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 01/10] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-07-31 15:52 ` Greg KH
2023-08-01 17:16 ` Hugo Villeneuve
2023-08-03 7:54 ` Greg KH
2023-08-03 13:04 ` Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 02/10] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-07-31 15:50 ` Greg KH
2023-07-31 16:22 ` Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 03/10] serial: sc16is7xx: remove obsolete out_thread label Hugo Villeneuve
2023-07-31 15:53 ` Greg KH [this message]
2023-08-01 17:29 ` Hugo Villeneuve
2023-08-03 7:55 ` Greg KH
2023-07-25 14:23 ` [PATCH v9 04/10] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-07-31 15:55 ` Greg KH
2023-08-03 16:14 ` Hugo Villeneuve
2023-08-04 13:14 ` Greg KH
2023-08-04 14:15 ` Hugo Villeneuve
2023-08-04 15:09 ` Greg KH
2023-08-07 14:57 ` Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 05/10] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 06/10] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-07-31 15:58 ` Greg KH
2023-08-03 14:18 ` Hugo Villeneuve
2023-08-03 21:04 ` Andy Shevchenko
2023-08-04 4:53 ` Greg KH
2023-07-25 14:23 ` [PATCH v9 07/10] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 08/10] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-07-31 15:59 ` Greg KH
2023-08-03 14:38 ` Hugo Villeneuve
2023-08-04 13:14 ` Greg KH
2023-07-25 14:23 ` [PATCH v9 09/10] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-07-31 15:57 ` Greg KH
2023-07-31 17:00 ` Hugo Villeneuve
2023-07-25 14:23 ` [PATCH v9 10/10] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
2023-07-31 15:56 ` Greg KH
2023-08-03 13:28 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023073135-puppy-reflected-700d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=isaac.true@canonical.com \
--cc=jesse.sung@canonical.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=lech.perczak@camlingroup.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).