From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 579DCC00528 for ; Mon, 31 Jul 2023 15:53:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231204AbjGaPxP (ORCPT ); Mon, 31 Jul 2023 11:53:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230382AbjGaPxO (ORCPT ); Mon, 31 Jul 2023 11:53:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A9D61BB; Mon, 31 Jul 2023 08:53:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 938FD611CD; Mon, 31 Jul 2023 15:53:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71AB1C433C8; Mon, 31 Jul 2023 15:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690818793; bh=L2tZXZmD+sXdaCCAuGFE2vWovGgLcHM5kSykAonNNRU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pmf1rBhcf2IvuO1HRVVazeKI85pL2NAawrpMNiTlOnq4vloDO3GiOKfezq+ghBcX4 X9w/xZMsXvTOgL9Hc/p72KdqRzwZ7m/m66c0T5BxRUCmD2MDS5ltLjxQ+uffTzmt18 NEC+EZ1hGciytwGGDO+wBsU5VApeZzIsDEWUdwhI= Date: Mon, 31 Jul 2023 17:53:10 +0200 From: Greg KH To: Hugo Villeneuve Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, isaac.true@canonical.com, jesse.sung@canonical.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Hugo Villeneuve , Lech Perczak , Andy Shevchenko Subject: Re: [PATCH v9 03/10] serial: sc16is7xx: remove obsolete out_thread label Message-ID: <2023073135-puppy-reflected-700d@gregkh> References: <20230725142343.1724130-1-hugo@hugovil.com> <20230725142343.1724130-4-hugo@hugovil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725142343.1724130-4-hugo@hugovil.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Jul 25, 2023 at 10:23:35AM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > Commit c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later > in probe") moved GPIO setup code later in probe function. Doing so > also required to move ports cleanup code (out_ports label) after the > GPIO cleanup code. > > After these moves, the out_thread label becomes misplaced and makes > part of the cleanup code illogical. > > This patch remove the now obsolete out_thread label and make GPIO > setup code jump to out_ports label if it fails. > > Fixes: c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later in probe") > Signed-off-by: Hugo Villeneuve > Reviewed-by: Lech Perczak > Tested-by: Lech Perczak > Reviewed-by: Andy Shevchenko Why is this not ok for stable kernels yet it has a Fixes: tag? Please fix. thanks, greg k-h