* [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata()
@ 2023-08-01 7:32 Andrei Coardos
2023-08-01 19:10 ` Andy Shevchenko
2023-08-03 13:45 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Andrei Coardos @ 2023-08-01 7:32 UTC (permalink / raw)
To: linux-kernel, linux-gpio
Cc: andy, brgl, linus.walleij, Andrei Coardos, Alexandru Ardelean
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/gpio/gpio-timberdale.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
index de14949a3fe5..bbd9e9191199 100644
--- a/drivers/gpio/gpio-timberdale.c
+++ b/drivers/gpio/gpio-timberdale.c
@@ -256,8 +256,6 @@ static int timbgpio_probe(struct platform_device *pdev)
if (err)
return err;
- platform_set_drvdata(pdev, tgpio);
-
/* make sure to disable interrupts */
iowrite32(0x0, tgpio->membase + TGPIO_IER);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata()
2023-08-01 7:32 [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata() Andrei Coardos
@ 2023-08-01 19:10 ` Andy Shevchenko
2023-08-03 13:45 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-08-01 19:10 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-gpio, brgl, linus.walleij, Alexandru Ardelean
On Tue, Aug 01, 2023 at 10:32:11AM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata()
2023-08-01 7:32 [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-01 19:10 ` Andy Shevchenko
@ 2023-08-03 13:45 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-08-03 13:45 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-gpio, andy, linus.walleij, Alexandru Ardelean
On Tue, Aug 1, 2023 at 9:32 AM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/gpio/gpio-timberdale.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
> index de14949a3fe5..bbd9e9191199 100644
> --- a/drivers/gpio/gpio-timberdale.c
> +++ b/drivers/gpio/gpio-timberdale.c
> @@ -256,8 +256,6 @@ static int timbgpio_probe(struct platform_device *pdev)
> if (err)
> return err;
>
> - platform_set_drvdata(pdev, tgpio);
> -
> /* make sure to disable interrupts */
> iowrite32(0x0, tgpio->membase + TGPIO_IER);
>
> --
> 2.34.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-03 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-01 7:32 [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-01 19:10 ` Andy Shevchenko
2023-08-03 13:45 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).