From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D0CAC001DF for ; Tue, 1 Aug 2023 11:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232204AbjHALPm (ORCPT ); Tue, 1 Aug 2023 07:15:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232458AbjHALPU (ORCPT ); Tue, 1 Aug 2023 07:15:20 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99C7CB0; Tue, 1 Aug 2023 04:12:46 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id DB788FF802; Tue, 1 Aug 2023 11:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690888365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U9XcoEVaGb/SzYJ6mJdNzeh0I7lywmTLcinYtPtZJ0c=; b=YeU1uU9DZXfTdXg8TFeI2o8Vqm7D8c1Fnm2DfojyufbZMvZGwcPjdBxRDg8U36hs3GEZNV RfioyzIjkZexR02ZLxdAkOfjwbF1bhjx0ieuUzu/mAHaPNwJQsd0PS6Wnw6126hLkLetZ5 Jje7zJ+VKap558GZ+oGgWv5oJscKoNwWOHSOTKJU+P4lyu+Gu5z5Nt6HjN3O7V25JsDewD ggblvVDvfqULX9YEURYbqlRVqkpWoTW7Z8jtWNqqW9U1XTZzNG+09ROmeraVwAd5Qf+Hqg +i4317dj/J6MOo8/Sais9wdrdmM/YCAHzsMdFKTCOSORGRoquZoMA+03nt5CQQ== Date: Tue, 1 Aug 2023 13:12:35 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20230801131235.10ad334a@bootlin.com> In-Reply-To: References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-24-herve.codina@bootlin.com> <4adae593-c428-4910-882e-7247727cf501@lunn.ch> <20230801124401.3883d16c@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, 1 Aug 2023 12:52:29 +0200 Andrew Lunn wrote: > > > > +static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, u8 isr) > > > > +{ > > > > + dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr); > > > > +} > > > > > > Should this be rate limited? It is going to be very noise if it gets > > > called once per frame time. > > > > This function should not be called. > > It is wired on some interrupts and these interrupts should not be triggered. > > It they fired, something was wrong. > > > > I would prefer to keep this dev_warn() to keep the user informed about the > > problem. > > I would definitely keep it, but rate limit it. dev_warn_ratelimited(). > > Andrew Ok, will be changed to dev_warn_ratelimited(). Hervé