linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: regression from commit b0ce9ce408b6 ("gpiolib: Do not unexport GPIO on freeing")
Date: Tue, 8 Aug 2023 10:28:28 +0200	[thread overview]
Message-ID: <20230808102828.4a9eac09@dellmb> (raw)

Hi,

the commit b0ce9ce408b6 ("gpiolib: Do not unexport GPIO on freeing")

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0ce9ce408b6

causes a regression on my mvebu arm board (haven't tested on other
systems), wherein if I export a GPIO to sysfs and then unexport it, it
does not disasppear from the /sys/class/gpio directory, and subsequent
writes to the export and unexport files for the gpio fail.

  $ cd /sys/class/gpio
  $ ls
  export       gpiochip0    gpiochip32   gpiochip512  unexport
  $ echo 43 >export
  $ ls
  export       gpio43       gpiochip0    gpiochip32   gpiochip512
  unexport
  $ cat gpio43/value
  1
  $ echo 43 >unexport
  $ ls
  export       gpio43       gpiochip0    gpiochip32   gpiochip512
  unexport
  $ echo 43 >unexport
  ash: write error: Invalid argument
  $ echo 43 >export
  ash: write error: Operation not permitted

Marek

             reply	other threads:[~2023-08-08 20:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  8:28 Marek Behún [this message]
2023-08-08 14:01 ` regression from commit b0ce9ce408b6 ("gpiolib: Do not unexport GPIO on freeing") Andy Shevchenko
2023-08-11 10:16 ` Andy Shevchenko
2023-08-14  7:39   ` Marek Behún
2023-08-14 11:18     ` Andy Shevchenko
2023-08-14 11:55       ` Marek Behún
2023-08-14 12:26         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808102828.4a9eac09@dellmb \
    --to=kabel@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).