From: Herve Codina <herve.codina@bootlin.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 21/28] net: wan: Add framer framework support
Date: Wed, 9 Aug 2023 17:01:39 +0200 [thread overview]
Message-ID: <20230809170139.2402e4a2@bootlin.com> (raw)
In-Reply-To: <cc9417a3-ef86-bb46-9519-cf65b03b5f08@infradead.org>
Hi Randy,
On Wed, 9 Aug 2023 07:24:32 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> Hi,
>
> On 8/9/23 06:27, Herve Codina wrote:
> > diff --git a/drivers/net/wan/framer/Kconfig b/drivers/net/wan/framer/Kconfig
> > new file mode 100644
> > index 000000000000..96ef1e7ba8eb
> > --- /dev/null
> > +++ b/drivers/net/wan/framer/Kconfig
> > @@ -0,0 +1,19 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +#
> > +# FRAMER
> > +#
> > +
> > +menu "Framer Subsystem"
> > +
> > +config GENERIC_FRAMER
> > + bool "Framer Core"
>
> Just curious: any reason that this cannot be tristate (i.e., a loadable module)?
> Thanks.
For the same reasons as generic phy cannot be built as module
b51fbf9fb0c3 phy-core: Don't allow building phy-core as a module
In the framer case, this allows to have the QMC HDLC driver built on systems
without any framers (no providers and no framer core framework).
Also the framer phandle is optional in the device tree QMC HDLC node.
Regards,
Hervé
>
> > + help
> > + Generic Framer support.
> > +
> > + This framework is designed to provide a generic interface for framer
> > + devices present in the kernel. This layer will have the generic
> > + API by which framer drivers can create framer using the framer
> > + framework and framer users can obtain reference to the framer.
> > + All the users of this framework should select this config.
> > +
> > +endmenu
>
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-08-09 15:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:27 [PATCH v3 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer Herve Codina
2023-08-09 13:27 ` [PATCH v3 01/28] soc: fsl: cpm1: tsa: Fix __iomem addresses declaration Herve Codina
2023-08-09 13:27 ` [PATCH v3 02/28] soc: fsl: cpm1: qmc: " Herve Codina
2023-08-09 13:27 ` [PATCH v3 03/28] soc: fsl: cpm1: qmc: Fix rx channel reset Herve Codina
2023-08-09 13:27 ` [PATCH v3 04/28] soc: fsl: cpm1: qmc: Extend the API to provide Rx status Herve Codina
2023-08-09 13:27 ` [PATCH v3 05/28] soc: fsl: cpm1: qmc: Remove inline function specifiers Herve Codina
2023-08-09 14:47 ` Christophe Leroy
2023-08-09 13:27 ` [PATCH v3 06/28] dt-bindings: net: Add support for QMC HDLC Herve Codina
2023-08-09 13:27 ` [PATCH v3 07/28] net: wan: " Herve Codina
2023-08-09 13:27 ` [PATCH v3 08/28] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2023-08-09 13:27 ` [PATCH v3 09/28] soc: fsl: cpm1: qmc: Introduce available timeslots masks Herve Codina
2023-08-09 13:27 ` [PATCH v3 10/28] soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* Herve Codina
2023-08-09 13:27 ` [PATCH v3 11/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* Herve Codina
2023-08-09 13:27 ` [PATCH v3 12/28] soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() Herve Codina
2023-08-09 13:27 ` [PATCH v3 13/28] soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() Herve Codina
2023-08-09 13:27 ` [PATCH v3 14/28] soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries Herve Codina
2023-08-09 13:27 ` [PATCH v3 15/28] soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup Herve Codina
2023-08-09 13:27 ` [PATCH v3 16/28] soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag Herve Codina
2023-08-09 13:27 ` [PATCH v3 17/28] soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() Herve Codina
2023-08-09 13:27 ` [PATCH v3 18/28] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Herve Codina
2023-08-09 13:27 ` [PATCH v3 19/28] soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime Herve Codina
2023-08-09 13:27 ` [PATCH v3 20/28] wan: qmc_hdlc: Add runtime timeslots changes support Herve Codina
2023-08-09 13:27 ` [PATCH v3 21/28] net: wan: Add framer framework support Herve Codina
2023-08-09 14:24 ` Randy Dunlap
2023-08-09 15:01 ` Herve Codina [this message]
2023-08-10 11:17 ` Linus Walleij
2023-08-09 13:27 ` [PATCH v3 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Herve Codina
2023-08-10 8:53 ` Linus Walleij
2023-08-16 15:49 ` Herve Codina
2023-08-09 13:27 ` [PATCH v3 23/28] mfd: core: Ensure disabled devices are skiped without aborting Herve Codina
2023-08-09 13:27 ` [PATCH v3 24/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Herve Codina
2023-08-09 13:27 ` [PATCH v3 25/28] pinctrl: Add support for the Lantic PEF2256 pinmux Herve Codina
2023-08-09 13:27 ` [PATCH v3 26/28] MAINTAINERS: Add the Lantiq PEF2256 driver entry Herve Codina
2023-08-09 13:27 ` [PATCH v3 27/28] ASoC: codecs: Add support for the framer codec Herve Codina
2023-08-09 13:27 ` [PATCH v3 28/28] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2023-08-10 15:47 ` [PATCH v3 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer Jakub Kicinski
2023-08-11 7:53 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809170139.2402e4a2@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=qiang.zhao@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).