From: kernel test robot <lkp@intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kent Gibson <warthog618@gmail.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 5/5] gpio: cdev: wake up lineevent poll() on device unbind
Date: Thu, 17 Aug 2023 17:12:58 +0800 [thread overview]
Message-ID: <202308171736.864z7YNW-lkp@intel.com> (raw)
In-Reply-To: <20230816122032.15548-6-brgl@bgdev.pl>
Hi Bartosz,
kernel test robot noticed the following build warnings:
[auto build test WARNING on brgl/gpio/for-next]
[also build test WARNING on linus/master v6.5-rc6 next-20230817]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/gpio-cdev-ignore-notifications-other-than-line-status-changes/20230816-202408
base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link: https://lore.kernel.org/r/20230816122032.15548-6-brgl%40bgdev.pl
patch subject: [PATCH 5/5] gpio: cdev: wake up lineevent poll() on device unbind
config: x86_64-randconfig-x016-20230817 (https://download.01.org/0day-ci/archive/20230817/202308171736.864z7YNW-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171736.864z7YNW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308171736.864z7YNW-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpio/gpiolib-cdev.c:1835: warning: Function parameter or member 'nb' not described in 'lineevent_state'
vim +1835 drivers/gpio/gpiolib-cdev.c
925ca36913fc7d Kent Gibson 2020-06-16 1807
925ca36913fc7d Kent Gibson 2020-06-16 1808 /*
925ca36913fc7d Kent Gibson 2020-06-16 1809 * GPIO line event management
925ca36913fc7d Kent Gibson 2020-06-16 1810 */
925ca36913fc7d Kent Gibson 2020-06-16 1811
925ca36913fc7d Kent Gibson 2020-06-16 1812 /**
925ca36913fc7d Kent Gibson 2020-06-16 1813 * struct lineevent_state - contains the state of a userspace event
925ca36913fc7d Kent Gibson 2020-06-16 1814 * @gdev: the GPIO device the event pertains to
925ca36913fc7d Kent Gibson 2020-06-16 1815 * @label: consumer label used to tag descriptors
925ca36913fc7d Kent Gibson 2020-06-16 1816 * @desc: the GPIO descriptor held by this event
925ca36913fc7d Kent Gibson 2020-06-16 1817 * @eflags: the event flags this line was requested with
925ca36913fc7d Kent Gibson 2020-06-16 1818 * @irq: the interrupt that trigger in response to events on this GPIO
925ca36913fc7d Kent Gibson 2020-06-16 1819 * @wait: wait queue that handles blocking reads of events
925ca36913fc7d Kent Gibson 2020-06-16 1820 * @events: KFIFO for the GPIO events
925ca36913fc7d Kent Gibson 2020-06-16 1821 * @timestamp: cache for the timestamp storing it between hardirq
925ca36913fc7d Kent Gibson 2020-06-16 1822 * and IRQ thread, used to bring the timestamp close to the actual
925ca36913fc7d Kent Gibson 2020-06-16 1823 * event
925ca36913fc7d Kent Gibson 2020-06-16 1824 */
925ca36913fc7d Kent Gibson 2020-06-16 1825 struct lineevent_state {
925ca36913fc7d Kent Gibson 2020-06-16 1826 struct gpio_device *gdev;
925ca36913fc7d Kent Gibson 2020-06-16 1827 const char *label;
925ca36913fc7d Kent Gibson 2020-06-16 1828 struct gpio_desc *desc;
925ca36913fc7d Kent Gibson 2020-06-16 1829 u32 eflags;
925ca36913fc7d Kent Gibson 2020-06-16 1830 int irq;
925ca36913fc7d Kent Gibson 2020-06-16 1831 wait_queue_head_t wait;
925ca36913fc7d Kent Gibson 2020-06-16 1832 DECLARE_KFIFO(events, struct gpioevent_data, 16);
35c059f377b978 Bartosz Golaszewski 2023-08-16 1833 struct notifier_block nb;
925ca36913fc7d Kent Gibson 2020-06-16 1834 u64 timestamp;
925ca36913fc7d Kent Gibson 2020-06-16 @1835 };
925ca36913fc7d Kent Gibson 2020-06-16 1836
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-08-17 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 12:20 [PATCH 0/5] gpio: cdev: bail out of poll() if the device goes down Bartosz Golaszewski
2023-08-16 12:20 ` [PATCH 1/5] gpio: cdev: ignore notifications other than line status changes Bartosz Golaszewski
2023-08-16 12:20 ` [PATCH 2/5] gpio: cdev: rename the notifier block and notify callback Bartosz Golaszewski
2023-08-16 12:20 ` [PATCH 3/5] gpio: cdev: wake up chardev poll() on device unbind Bartosz Golaszewski
2023-08-16 12:20 ` [PATCH 4/5] gpio: cdev: wake up linereq " Bartosz Golaszewski
2023-08-16 12:20 ` [PATCH 5/5] gpio: cdev: wake up lineevent " Bartosz Golaszewski
2023-08-17 9:12 ` kernel test robot [this message]
2023-08-16 21:41 ` [PATCH 0/5] gpio: cdev: bail out of poll() if the device goes down Linus Walleij
2023-08-17 4:41 ` Kent Gibson
2023-08-17 7:00 ` Linus Walleij
2023-08-17 7:27 ` Bartosz Golaszewski
2023-08-17 7:37 ` Kent Gibson
2023-08-17 7:41 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308171736.864z7YNW-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).