From: Asmaa Mnebhi <asmaa@nvidia.com>
To: <andy.shevchenko@gmail.com>, <linux-gpio@vger.kernel.org>,
<linus.walleij@linaro.org>, <bgolaszewski@baylibre.com>,
<brgl@bgdev.pl>, <linux-kernel@vger.kernel.org>
Cc: Asmaa Mnebhi <asmaa@nvidia.com>
Subject: [PATCH v3 0/2] Fix Nvidia BlueField-3 GPIO access
Date: Thu, 17 Aug 2023 21:21:09 -0400 [thread overview]
Message-ID: <20230818012111.22947-1-asmaa@nvidia.com> (raw)
Fix Nvidia BlueField-3 GPIO access via libgpiod gpioset tool.
gpioset tool fails to modify the GPIO value due to the following:
1) the pinctrl-mlxbf3 driver defines mlxbf3_gpio_request_enable()
to enable software to take control over a gpio. Only then can
the gpio-mlxbf3 driver modify the direction and value of the
gpio. mlxbf3_gpio_disable_free() gives control back to hardware
and is called when the "gpioset" command is invoked.
This cancels out the effort to change the GPIO value and
direction. So mlxbf3_gpio_disable_free() needs to be removed.
2) the gpio-mlxbf3 driver calls gpiochip_generic_request() which
calls mlxbf3_gpio_request_enable(). "pin_ranges" needs not to be
empty for mlxbf3_gpio_request_enable() to be invoked. So
gpio-mlxbf3 needs to populate "pin_ranges".
Asmaa Mnebhi (2):
pinctrl: mlxbf3: Remove gpio_disable_free()
gpio: mlxbf3: Support add_pin_ranges()
drivers/gpio/gpio-mlxbf3.c | 24 ++++++++++++++++++++++++
drivers/pinctrl/pinctrl-mlxbf3.c | 14 --------------
2 files changed, 24 insertions(+), 14 deletions(-)
--
2.30.1
next reply other threads:[~2023-08-18 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 1:21 Asmaa Mnebhi [this message]
2023-08-18 1:21 ` [PATCH v3 1/2] pinctrl: mlxbf3: Remove gpio_disable_free() Asmaa Mnebhi
2023-08-18 1:21 ` [PATCH v3 2/2] gpio: mlxbf3: Support add_pin_ranges() Asmaa Mnebhi
2023-08-18 8:59 ` Andy Shevchenko
2023-08-18 12:08 ` Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818012111.22947-1-asmaa@nvidia.com \
--to=asmaa@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).