* [PATCH 0/2] gpio: pca953x: add support for TCA9538
@ 2023-08-24 23:16 Liam Beguin
2023-08-24 23:16 ` [PATCH 1/2] " Liam Beguin
2023-08-24 23:16 ` [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip Liam Beguin
0 siblings, 2 replies; 7+ messages in thread
From: Liam Beguin @ 2023-08-24 23:16 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-gpio, linux-kernel, Krzysztof Kozlowski, devicetree,
Liam Beguin
The TCA9538 is an 8 bit version of the already supported TCA9539.
This chip also has interrupt support.
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
---
Liam Beguin (2):
gpio: pca953x: add support for TCA9538
dt-bindings: gpio: pca95xx: document new tca9538 chip
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
drivers/gpio/gpio-pca953x.c | 2 ++
2 files changed, 3 insertions(+)
---
base-commit: a5e505a99ca748583dbe558b691be1b26f05d678
change-id: 20230824-tca9538-4dbf8d93f1ba
Best regards,
--
Liam Beguin <liambeguin@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] gpio: pca953x: add support for TCA9538
2023-08-24 23:16 [PATCH 0/2] gpio: pca953x: add support for TCA9538 Liam Beguin
@ 2023-08-24 23:16 ` Liam Beguin
2023-08-25 1:59 ` Andy Shevchenko
2023-08-25 11:18 ` Bartosz Golaszewski
2023-08-24 23:16 ` [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip Liam Beguin
1 sibling, 2 replies; 7+ messages in thread
From: Liam Beguin @ 2023-08-24 23:16 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-gpio, linux-kernel, Krzysztof Kozlowski, devicetree,
Liam Beguin
The TCA9538 is an 8 bit version of the already supported TCA9539.
This chip also has interrupt support.
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
---
drivers/gpio/gpio-pca953x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index a806a3c1b801..71a750363738 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -108,6 +108,7 @@ static const struct i2c_device_id pca953x_id[] = {
{ "tca6408", 8 | PCA953X_TYPE | PCA_INT, },
{ "tca6416", 16 | PCA953X_TYPE | PCA_INT, },
{ "tca6424", 24 | PCA953X_TYPE | PCA_INT, },
+ { "tca9538", 8 | PCA953X_TYPE | PCA_INT, },
{ "tca9539", 16 | PCA953X_TYPE | PCA_INT, },
{ "tca9554", 8 | PCA953X_TYPE | PCA_INT, },
{ "xra1202", 8 | PCA953X_TYPE },
@@ -1354,6 +1355,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
{ .compatible = "ti,tca6408", .data = OF_953X( 8, PCA_INT), },
{ .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
{ .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
+ { .compatible = "ti,tca9538", .data = OF_953X( 8, PCA_INT), },
{ .compatible = "ti,tca9539", .data = OF_953X(16, PCA_INT), },
{ .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
--
2.39.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip
2023-08-24 23:16 [PATCH 0/2] gpio: pca953x: add support for TCA9538 Liam Beguin
2023-08-24 23:16 ` [PATCH 1/2] " Liam Beguin
@ 2023-08-24 23:16 ` Liam Beguin
2023-08-25 6:21 ` Krzysztof Kozlowski
2023-08-25 11:17 ` Bartosz Golaszewski
1 sibling, 2 replies; 7+ messages in thread
From: Liam Beguin @ 2023-08-24 23:16 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-gpio, linux-kernel, Krzysztof Kozlowski, devicetree,
Liam Beguin
The previous patch added support for this chip. Add its name to the list
of allowed compatibles.
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
---
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index fa116148ee90..99febb8ea1b6 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -66,6 +66,7 @@ properties:
- ti,tca6408
- ti,tca6416
- ti,tca6424
+ - ti,tca9538
- ti,tca9539
- ti,tca9554
--
2.39.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] gpio: pca953x: add support for TCA9538
2023-08-24 23:16 ` [PATCH 1/2] " Liam Beguin
@ 2023-08-25 1:59 ` Andy Shevchenko
2023-08-25 11:18 ` Bartosz Golaszewski
1 sibling, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2023-08-25 1:59 UTC (permalink / raw)
To: Liam Beguin
Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-gpio, linux-kernel,
Krzysztof Kozlowski, devicetree
On Thu, Aug 24, 2023 at 07:16:25PM -0400, Liam Beguin wrote:
> The TCA9538 is an 8 bit version of the already supported TCA9539.
> This chip also has interrupt support.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip
2023-08-24 23:16 ` [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip Liam Beguin
@ 2023-08-25 6:21 ` Krzysztof Kozlowski
2023-08-25 11:17 ` Bartosz Golaszewski
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-25 6:21 UTC (permalink / raw)
To: Liam Beguin, Linus Walleij, Bartosz Golaszewski, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-gpio, linux-kernel, Krzysztof Kozlowski, devicetree
On 25/08/2023 01:16, Liam Beguin wrote:
> The previous patch added support for this chip.
This is not needed. If by any chance this would go via different trees,
it would stop to make any sense.
Also, is wrong. Bindings come *always* before the users.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip
2023-08-24 23:16 ` [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip Liam Beguin
2023-08-25 6:21 ` Krzysztof Kozlowski
@ 2023-08-25 11:17 ` Bartosz Golaszewski
1 sibling, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-08-25 11:17 UTC (permalink / raw)
To: Liam Beguin
Cc: Linus Walleij, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-gpio, linux-kernel, Krzysztof Kozlowski,
devicetree
On Fri, Aug 25, 2023 at 1:16 AM Liam Beguin <liambeguin@gmail.com> wrote:
>
> The previous patch added support for this chip. Add its name to the list
> of allowed compatibles.
>
> Signed-off-by: Liam Beguin <liambeguin@gmail.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> index fa116148ee90..99febb8ea1b6 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> @@ -66,6 +66,7 @@ properties:
> - ti,tca6408
> - ti,tca6416
> - ti,tca6424
> + - ti,tca9538
> - ti,tca9539
> - ti,tca9554
>
>
> --
> 2.39.0
>
Applied with commit message tweaked.
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] gpio: pca953x: add support for TCA9538
2023-08-24 23:16 ` [PATCH 1/2] " Liam Beguin
2023-08-25 1:59 ` Andy Shevchenko
@ 2023-08-25 11:18 ` Bartosz Golaszewski
1 sibling, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-08-25 11:18 UTC (permalink / raw)
To: Liam Beguin
Cc: Linus Walleij, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-gpio, linux-kernel, Krzysztof Kozlowski,
devicetree
On Fri, Aug 25, 2023 at 1:16 AM Liam Beguin <liambeguin@gmail.com> wrote:
>
> The TCA9538 is an 8 bit version of the already supported TCA9539.
> This chip also has interrupt support.
>
> Signed-off-by: Liam Beguin <liambeguin@gmail.com>
> ---
> drivers/gpio/gpio-pca953x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index a806a3c1b801..71a750363738 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -108,6 +108,7 @@ static const struct i2c_device_id pca953x_id[] = {
> { "tca6408", 8 | PCA953X_TYPE | PCA_INT, },
> { "tca6416", 16 | PCA953X_TYPE | PCA_INT, },
> { "tca6424", 24 | PCA953X_TYPE | PCA_INT, },
> + { "tca9538", 8 | PCA953X_TYPE | PCA_INT, },
> { "tca9539", 16 | PCA953X_TYPE | PCA_INT, },
> { "tca9554", 8 | PCA953X_TYPE | PCA_INT, },
> { "xra1202", 8 | PCA953X_TYPE },
> @@ -1354,6 +1355,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
> { .compatible = "ti,tca6408", .data = OF_953X( 8, PCA_INT), },
> { .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
> { .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
> + { .compatible = "ti,tca9538", .data = OF_953X( 8, PCA_INT), },
> { .compatible = "ti,tca9539", .data = OF_953X(16, PCA_INT), },
>
> { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
>
> --
> 2.39.0
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-25 11:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24 23:16 [PATCH 0/2] gpio: pca953x: add support for TCA9538 Liam Beguin
2023-08-24 23:16 ` [PATCH 1/2] " Liam Beguin
2023-08-25 1:59 ` Andy Shevchenko
2023-08-25 11:18 ` Bartosz Golaszewski
2023-08-24 23:16 ` [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip Liam Beguin
2023-08-25 6:21 ` Krzysztof Kozlowski
2023-08-25 11:17 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).