[PATCH 0/2] gpio: pca953x: add support for TCA9538

[PATCH 0/2] gpio: pca953x: add support for TCA9538

[Liam Beguin]

The TCA9538 is an 8 bit version of the already supported TCA9539.
This chip also has interrupt support.

Signed-off-by: Liam Beguin <liambeguin@gmail.com>
---
Liam Beguin (2):
      gpio: pca953x: add support for TCA9538
      dt-bindings: gpio: pca95xx: document new tca9538 chip

 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
 drivers/gpio/gpio-pca953x.c                              | 2 ++
 2 files changed, 3 insertions(+)
---
base-commit: a5e505a99ca748583dbe558b691be1b26f05d678
change-id: 20230824-tca9538-4dbf8d93f1ba

Best regards,
-- 
Liam Beguin <liambeguin@gmail.com>

[PATCH 1/2] gpio: pca953x: add support for TCA9538

[Liam Beguin]

The TCA9538 is an 8 bit version of the already supported TCA9539.
This chip also has interrupt support.

Signed-off-by: Liam Beguin <liambeguin@gmail.com>
---
 drivers/gpio/gpio-pca953x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index a806a3c1b801..71a750363738 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -108,6 +108,7 @@ static const struct i2c_device_id pca953x_id[] = {
 	{ "tca6408", 8  | PCA953X_TYPE | PCA_INT, },
 	{ "tca6416", 16 | PCA953X_TYPE | PCA_INT, },
 	{ "tca6424", 24 | PCA953X_TYPE | PCA_INT, },
+	{ "tca9538", 8  | PCA953X_TYPE | PCA_INT, },
 	{ "tca9539", 16 | PCA953X_TYPE | PCA_INT, },
 	{ "tca9554", 8  | PCA953X_TYPE | PCA_INT, },
 	{ "xra1202", 8  | PCA953X_TYPE },
@@ -1354,6 +1355,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
 	{ .compatible = "ti,tca6408", .data = OF_953X( 8, PCA_INT), },
 	{ .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
 	{ .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
+	{ .compatible = "ti,tca9538", .data = OF_953X( 8, PCA_INT), },
 	{ .compatible = "ti,tca9539", .data = OF_953X(16, PCA_INT), },
 
 	{ .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },

-- 
2.39.0

Re: [PATCH 1/2] gpio: pca953x: add support for TCA9538

[Andy Shevchenko]

On Thu, Aug 24, 2023 at 07:16:25PM -0400, Liam Beguin wrote:
> The TCA9538 is an 8 bit version of the already supported TCA9539.
> This chip also has interrupt support.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/2] gpio: pca953x: add support for TCA9538

[Bartosz Golaszewski]

On Fri, Aug 25, 2023 at 1:16 AM Liam Beguin <liambeguin@gmail.com> wrote:
>
> The TCA9538 is an 8 bit version of the already supported TCA9539.
> This chip also has interrupt support.
>
> Signed-off-by: Liam Beguin <liambeguin@gmail.com>
> ---
>  drivers/gpio/gpio-pca953x.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index a806a3c1b801..71a750363738 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -108,6 +108,7 @@ static const struct i2c_device_id pca953x_id[] = {
>         { "tca6408", 8  | PCA953X_TYPE | PCA_INT, },
>         { "tca6416", 16 | PCA953X_TYPE | PCA_INT, },
>         { "tca6424", 24 | PCA953X_TYPE | PCA_INT, },
> +       { "tca9538", 8  | PCA953X_TYPE | PCA_INT, },
>         { "tca9539", 16 | PCA953X_TYPE | PCA_INT, },
>         { "tca9554", 8  | PCA953X_TYPE | PCA_INT, },
>         { "xra1202", 8  | PCA953X_TYPE },
> @@ -1354,6 +1355,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
>         { .compatible = "ti,tca6408", .data = OF_953X( 8, PCA_INT), },
>         { .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
>         { .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
> +       { .compatible = "ti,tca9538", .data = OF_953X( 8, PCA_INT), },
>         { .compatible = "ti,tca9539", .data = OF_953X(16, PCA_INT), },
>
>         { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
>
> --
> 2.39.0
>

Applied, thanks!

Bart

[PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip

[Liam Beguin]

The previous patch added support for this chip. Add its name to the list
of allowed compatibles.

Signed-off-by: Liam Beguin <liambeguin@gmail.com>
---
 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index fa116148ee90..99febb8ea1b6 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -66,6 +66,7 @@ properties:
               - ti,tca6408
               - ti,tca6416
               - ti,tca6424
+              - ti,tca9538
               - ti,tca9539
               - ti,tca9554
 

-- 
2.39.0

Re: [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip

[Krzysztof Kozlowski]

On 25/08/2023 01:16, Liam Beguin wrote:
> The previous patch added support for this chip. 

This is not needed. If by any chance this would go via different trees,
it would stop to make any sense.

Also, is wrong. Bindings come *always* before the users.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: gpio: pca95xx: document new tca9538 chip

[Bartosz Golaszewski]

On Fri, Aug 25, 2023 at 1:16 AM Liam Beguin <liambeguin@gmail.com> wrote:
>
> The previous patch added support for this chip. Add its name to the list
> of allowed compatibles.
>
> Signed-off-by: Liam Beguin <liambeguin@gmail.com>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> index fa116148ee90..99febb8ea1b6 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> @@ -66,6 +66,7 @@ properties:
>                - ti,tca6408
>                - ti,tca6416
>                - ti,tca6424
> +              - ti,tca9538
>                - ti,tca9539
>                - ti,tca9554
>
>
> --
> 2.39.0
>

Applied with commit message tweaked.

Bart