linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: single: remove get rid of __maybe_unused
@ 2023-08-24  6:45 Masahiro Yamada
  2023-09-11  8:49 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2023-08-24  6:45 UTC (permalink / raw)
  To: Linus Walleij, linux-gpio
  Cc: linux-kernel, Masahiro Yamada, Haojian Zhuang, Tony Lindgren,
	linux-arm-kernel, linux-omap

These are always used in pcs_probe().

While I was here, I also changed 'unsigned' in the same line to
'unsigned int' to address the checkpatch warnings:

  WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 drivers/pinctrl/pinctrl-single.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 0dabbcf68b9f..51783fa62c1c 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -240,32 +240,32 @@ static struct lock_class_key pcs_request_class;
  * does not help in this case.
  */
 
-static unsigned __maybe_unused pcs_readb(void __iomem *reg)
+static unsigned int pcs_readb(void __iomem *reg)
 {
 	return readb(reg);
 }
 
-static unsigned __maybe_unused pcs_readw(void __iomem *reg)
+static unsigned int pcs_readw(void __iomem *reg)
 {
 	return readw(reg);
 }
 
-static unsigned __maybe_unused pcs_readl(void __iomem *reg)
+static unsigned int pcs_readl(void __iomem *reg)
 {
 	return readl(reg);
 }
 
-static void __maybe_unused pcs_writeb(unsigned val, void __iomem *reg)
+static void pcs_writeb(unsigned int val, void __iomem *reg)
 {
 	writeb(val, reg);
 }
 
-static void __maybe_unused pcs_writew(unsigned val, void __iomem *reg)
+static void pcs_writew(unsigned int val, void __iomem *reg)
 {
 	writew(val, reg);
 }
 
-static void __maybe_unused pcs_writel(unsigned val, void __iomem *reg)
+static void pcs_writel(unsigned int val, void __iomem *reg)
 {
 	writel(val, reg);
 }
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pinctrl: single: remove get rid of __maybe_unused
  2023-08-24  6:45 [PATCH] pinctrl: single: remove get rid of __maybe_unused Masahiro Yamada
@ 2023-09-11  8:49 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-09-11  8:49 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: linux-gpio, linux-kernel, Haojian Zhuang, Tony Lindgren,
	linux-arm-kernel, linux-omap

On Thu, Aug 24, 2023 at 8:45 AM Masahiro Yamada <masahiroy@kernel.org> wrote:

> These are always used in pcs_probe().
>
> While I was here, I also changed 'unsigned' in the same line to
> 'unsigned int' to address the checkpatch warnings:
>
>   WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-11 21:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24  6:45 [PATCH] pinctrl: single: remove get rid of __maybe_unused Masahiro Yamada
2023-09-11  8:49 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).