* [PATCH] gpio: dwapb: don't include gpiolib.h
@ 2023-09-06 14:50 Bartosz Golaszewski
2023-09-06 21:22 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-09-06 14:50 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko
Cc: linux-gpio, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The gpiolib.h is unnecessarily included in the driver. None of its
symbols are used so drop it.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-dwapb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index c22fcaa44a61..4a4f61bf6c58 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -21,7 +21,6 @@
#include <linux/slab.h>
#include <linux/spinlock.h>
-#include "gpiolib.h"
#include "gpiolib-acpi.h"
#define GPIO_SWPORTA_DR 0x00
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: dwapb: don't include gpiolib.h
2023-09-06 14:50 [PATCH] gpio: dwapb: don't include gpiolib.h Bartosz Golaszewski
@ 2023-09-06 21:22 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-09-06 21:22 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Shevchenko, linux-gpio, linux-kernel, Bartosz Golaszewski
On Wed, Sep 6, 2023 at 4:50 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The gpiolib.h is unnecessarily included in the driver. None of its
> symbols are used so drop it.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-06 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-06 14:50 [PATCH] gpio: dwapb: don't include gpiolib.h Bartosz Golaszewski
2023-09-06 21:22 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).