From: Jernej Skrabec <jernej.skrabec@gmail.com>
To: linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@gmail.com>
Subject: [PATCH v2 2/2] pinctrl: pinmux: Use dev_err_probe() in pin_request()
Date: Sat, 9 Sep 2023 16:34:57 +0200 [thread overview]
Message-ID: <20230909143457.9149-3-jernej.skrabec@gmail.com> (raw)
In-Reply-To: <20230909143457.9149-1-jernej.skrabec@gmail.com>
Use dev_err_probe() when printing error message in pin_request() since
it may fail with -EPROBE_DEFER.
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
drivers/pinctrl/pinmux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index 301fe0157b02..0ecd74ce5890 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -188,8 +188,8 @@ static int pin_request(struct pinctrl_dev *pctldev,
}
out:
if (status)
- dev_err(pctldev->dev, "pin-%d (%s) status %d\n",
- pin, owner, status);
+ dev_err_probe(pctldev->dev, status, "pin-%d (%s)\n",
+ pin, owner);
return status;
}
--
2.42.0
prev parent reply other threads:[~2023-09-09 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 14:34 [PATCH v2 0/2] pinctrl: pinmux: Update error reporting in pin_request() Jernej Skrabec
2023-09-09 14:34 ` [PATCH v2 1/2] pinctrl: pinmux: Remove duplicate error message " Jernej Skrabec
2023-09-09 14:34 ` Jernej Skrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230909143457.9149-3-jernej.skrabec@gmail.com \
--to=jernej.skrabec@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).