* [PATCH] pinctrl: nuvoton: Fix up Kconfig deps
@ 2023-09-13 8:50 Linus Walleij
2023-09-13 17:12 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2023-09-13 8:50 UTC (permalink / raw)
To: Tomer Maimon; +Cc: linux-gpio, linux-kernel, Randy Dunlap, Linus Walleij
We have build errors due to missing dependency on OF.
Add the dependency and do it the same way for all three
Nuvotons while we are at it.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/nuvoton/Kconfig | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
index 612e7ba02238..2abbfcec1fae 100644
--- a/drivers/pinctrl/nuvoton/Kconfig
+++ b/drivers/pinctrl/nuvoton/Kconfig
@@ -2,8 +2,7 @@
config PINCTRL_WPCM450
tristate "Pinctrl and GPIO driver for Nuvoton WPCM450"
- depends on ARCH_WPCM450 || COMPILE_TEST
- depends on OF
+ depends on (ARCH_WPCM450 || COMPILE_TEST) && OF
select PINMUX
select PINCONF
select GENERIC_PINCONF
@@ -35,7 +34,7 @@ config PINCTRL_NPCM7XX
config PINCTRL_NPCM8XX
tristate "Pinctrl and GPIO driver for Nuvoton NPCM8XX"
- depends on ARCH_NPCM || COMPILE_TEST
+ depends on (ARCH_NPCM || COMPILE_TEST) && OF
select PINMUX
select PINCONF
select GENERIC_PINCONF
---
base-commit: c9336ebe87e77f92ed04a86c0131a0310d0e200d
change-id: 20230913-novoton-kconfig-895c60755500
Best regards,
--
Linus Walleij <linus.walleij@linaro.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: nuvoton: Fix up Kconfig deps
2023-09-13 8:50 [PATCH] pinctrl: nuvoton: Fix up Kconfig deps Linus Walleij
@ 2023-09-13 17:12 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2023-09-13 17:12 UTC (permalink / raw)
To: Linus Walleij, Tomer Maimon; +Cc: linux-gpio, linux-kernel
On 9/13/23 01:50, Linus Walleij wrote:
> We have build errors due to missing dependency on OF.
> Add the dependency and do it the same way for all three
> Nuvotons while we are at it.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/pinctrl/nuvoton/Kconfig | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
> index 612e7ba02238..2abbfcec1fae 100644
> --- a/drivers/pinctrl/nuvoton/Kconfig
> +++ b/drivers/pinctrl/nuvoton/Kconfig
> @@ -2,8 +2,7 @@
>
> config PINCTRL_WPCM450
> tristate "Pinctrl and GPIO driver for Nuvoton WPCM450"
> - depends on ARCH_WPCM450 || COMPILE_TEST
> - depends on OF
> + depends on (ARCH_WPCM450 || COMPILE_TEST) && OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> @@ -35,7 +34,7 @@ config PINCTRL_NPCM7XX
>
> config PINCTRL_NPCM8XX
> tristate "Pinctrl and GPIO driver for Nuvoton NPCM8XX"
> - depends on ARCH_NPCM || COMPILE_TEST
> + depends on (ARCH_NPCM || COMPILE_TEST) && OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
>
> ---
> base-commit: c9336ebe87e77f92ed04a86c0131a0310d0e200d
> change-id: 20230913-novoton-kconfig-895c60755500
>
> Best regards,
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-13 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 8:50 [PATCH] pinctrl: nuvoton: Fix up Kconfig deps Linus Walleij
2023-09-13 17:12 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).