From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E63EDEC71 for ; Wed, 13 Sep 2023 14:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238573AbjIMO7y (ORCPT ); Wed, 13 Sep 2023 10:59:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233101AbjIMO7y (ORCPT ); Wed, 13 Sep 2023 10:59:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16A63AF; Wed, 13 Sep 2023 07:59:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5EDBC433C8; Wed, 13 Sep 2023 14:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694617189; bh=0AbGKrvHkbfmwX2tPrwgjwFrlaY/UK4+5XEpUO6Hmk4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kTHkg6U2OrOp9s11X766GHIMjWESKKOX2vVpe8mIR0Uj+fuatFjupPtR2QKTXjtvr yyq629oLWrJZv+fhaxlXXihlD2CL9SRcmFJxZ8ymQ7v8nI9z6dQ/jBBE+k4T0d3kMe 5tQht4mgII3Zt3IH/dXx1sf9mZwYIGqQ4X4/Dln/R5QcTVQP15KQBtU2vb1CRKj3Tm IU+/n1n/1z40lgmI+EInQ2RPMp8hCqzl+luIqDX7rKrHaQGADi9yhBRcOlIxyoZCoG cx1xy8qPJKijtLTyaYqY7uoFqT9m+fIg+j0pngkk0UI2/lR0L9uwBTuK8kFzbFhRsL Ok847V3L9PMGQ== Date: Wed, 13 Sep 2023 15:59:41 +0100 From: Conor Dooley To: Herve Codina Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC Message-ID: <20230913-unburned-overturn-41b83e1eed25@spud> References: <20230912081527.208499-1-herve.codina@bootlin.com> <20230912101018.225246-1-herve.codina@bootlin.com> <20230912-capable-stash-c7a3e33078ac@spud> <20230913092640.76934b31@bootlin.com> <20230913-unruly-recite-7dbbbd7e63e0@spud> <20230913165250.02bab2ad@bootlin.com> <20230913-oversold-delay-05368e5de9fe@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k94xrof+2xueRHia" Content-Disposition: inline In-Reply-To: <20230913-oversold-delay-05368e5de9fe@spud> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --k94xrof+2xueRHia Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 13, 2023 at 03:56:16PM +0100, Conor Dooley wrote: > On Wed, Sep 13, 2023 at 04:52:50PM +0200, Herve Codina wrote: > > On Wed, 13 Sep 2023 15:42:45 +0100 > > Conor Dooley wrote: > >=20 > > > On Wed, Sep 13, 2023 at 09:26:40AM +0200, Herve Codina wrote: > > > > Hi Conor, > > > >=20 > > > > On Tue, 12 Sep 2023 18:21:58 +0100 > > > > Conor Dooley wrote: > > > > =20 > > > > > On Tue, Sep 12, 2023 at 12:10:18PM +0200, Herve Codina wrote: =20 > > > > > > The QMC (QUICC mutichannel controller) is a controller present = in some > > > > > > PowerQUICC SoC such as MPC885. > > > > > > The QMC HDLC uses the QMC controller to transfer HDLC data. > > > > > >=20 > > > > > > Additionally, a framer can be connected to the QMC HDLC. > > > > > > If present, this framer is the interface between the TDM bus us= ed by the > > > > > > QMC HDLC and the E1/T1 line. > > > > > > The QMC HDLC can use this framer to get information about the E= 1/T1 line > > > > > > and configure the E1/T1 line. > > > > > >=20 > > > > > > Signed-off-by: Herve Codina > > > > > > --- > > > > > > .../bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml | 13 +++++= ++++++++ > > > > > > 1 file changed, 13 insertions(+) > > > > > >=20 > > > > > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/f= sl,cpm1-scc-qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl= ,cpm1-scc-qmc.yaml > > > > > > index 82d9beb48e00..b5073531f3f1 100644 > > > > > > --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1= -scc-qmc.yaml > > > > > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1= -scc-qmc.yaml > > > > > > @@ -101,6 +101,16 @@ patternProperties: > > > > > > Channel assigned Rx time-slots within the Rx time-sl= ots routed by the > > > > > > TSA to this cell. > > > > > > =20 > > > > > > + compatible: > > > > > > + const: fsl,qmc-hdlc > > > > > > + > > > > > > + fsl,framer: > > > > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > > > > + description: > > > > > > + phandle to the framer node. The framer is in charge = of an E1/T1 line > > > > > > + interface connected to the TDM bus. It can be used t= o get the E1/T1 line > > > > > > + status such as link up/down. =20 > > > > >=20 > > > > > Sounds like this fsl,framer property should depend on the compati= ble > > > > > being present, no? =20 > > > >=20 > > > > Well from the implementation point of view, only the QMC HDLC drive= r uses this > > > > property. > > > >=20 > > > > From the hardware description point of view, this property means th= at the time slots > > > > handled by this channel are connected to the framer. So I think it = makes sense for > > > > any channel no matter the compatible (even if compatible is not pre= sent). > > > >=20 > > > > Should I change and constraint the fsl,framer property to the compa= tible presence ? > > > > If so, is the following correct for this contraint ? > > > > --- 8< --- > > > > dependencies: > > > > - fsl,framer: [ compatible ]; > > > > --- 8< --- =20 > > >=20 > > > The regular sort of > > > if: > > > compatible: > > > contains: > > > const: foo > > > then: > > > required: > > > - fsl,framer > > > would fit the bill, no? > >=20 > > Not sure. > > "fsl,framer" is an optional property (depending on the hardware we can = have > > a framer or not). >=20 > Ah apologies, I had it backwards! Your suggestion seems fair in that > case. Or actually, if: compatible: not: contains: const: foo then: properties: fsl,framer: false ? That should do the trick in a more conventional way. --k94xrof+2xueRHia Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQHOXQAKCRB4tDGHoIJi 0poQAQDqNLWYV0v7EFgrkPDKkkHvvsg4hXdY0+WRr/xipZ7pfQEAux/D0zjPvPjQ t36Kzm5ducMZfS17zQJL3mrN2qrf3gA= =C+xz -----END PGP SIGNATURE----- --k94xrof+2xueRHia--