From: Conor Dooley <conor@kernel.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Randy Dunlap <rdunlap@infradead.org>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, Simon Horman <horms@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC
Date: Wed, 13 Sep 2023 15:42:45 +0100 [thread overview]
Message-ID: <20230913-unruly-recite-7dbbbd7e63e0@spud> (raw)
In-Reply-To: <20230913092640.76934b31@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2730 bytes --]
On Wed, Sep 13, 2023 at 09:26:40AM +0200, Herve Codina wrote:
> Hi Conor,
>
> On Tue, 12 Sep 2023 18:21:58 +0100
> Conor Dooley <conor@kernel.org> wrote:
>
> > On Tue, Sep 12, 2023 at 12:10:18PM +0200, Herve Codina wrote:
> > > The QMC (QUICC mutichannel controller) is a controller present in some
> > > PowerQUICC SoC such as MPC885.
> > > The QMC HDLC uses the QMC controller to transfer HDLC data.
> > >
> > > Additionally, a framer can be connected to the QMC HDLC.
> > > If present, this framer is the interface between the TDM bus used by the
> > > QMC HDLC and the E1/T1 line.
> > > The QMC HDLC can use this framer to get information about the E1/T1 line
> > > and configure the E1/T1 line.
> > >
> > > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> > > ---
> > > .../bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> > > index 82d9beb48e00..b5073531f3f1 100644
> > > --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> > > @@ -101,6 +101,16 @@ patternProperties:
> > > Channel assigned Rx time-slots within the Rx time-slots routed by the
> > > TSA to this cell.
> > >
> > > + compatible:
> > > + const: fsl,qmc-hdlc
> > > +
> > > + fsl,framer:
> > > + $ref: /schemas/types.yaml#/definitions/phandle
> > > + description:
> > > + phandle to the framer node. The framer is in charge of an E1/T1 line
> > > + interface connected to the TDM bus. It can be used to get the E1/T1 line
> > > + status such as link up/down.
> >
> > Sounds like this fsl,framer property should depend on the compatible
> > being present, no?
>
> Well from the implementation point of view, only the QMC HDLC driver uses this
> property.
>
> From the hardware description point of view, this property means that the time slots
> handled by this channel are connected to the framer. So I think it makes sense for
> any channel no matter the compatible (even if compatible is not present).
>
> Should I change and constraint the fsl,framer property to the compatible presence ?
> If so, is the following correct for this contraint ?
> --- 8< ---
> dependencies:
> - fsl,framer: [ compatible ];
> --- 8< ---
The regular sort of
if:
compatible:
contains:
const: foo
then:
required:
- fsl,framer
would fit the bill, no?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-13 14:42 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 8:14 [PATCH v5 00/31] Add support for QMC HDLC, framer infrastructure and PEF2256 framer Herve Codina
2023-09-12 8:14 ` [PATCH v5 01/31] soc: fsl: cpm1: tsa: Fix __iomem addresses declaration Herve Codina
2023-09-12 8:14 ` [PATCH v5 02/31] soc: fsl: cpm1: qmc: " Herve Codina
2023-09-12 8:14 ` [PATCH v5 03/31] soc: fsl: cpm1: qmc: Fix rx channel reset Herve Codina
2023-09-12 8:14 ` [PATCH v5 04/31] soc: fsl: cpm1: qmc: Extend the API to provide Rx status Herve Codina
2023-09-12 8:14 ` [PATCH v5 05/31] soc: fsl: cpm1: qmc: Remove inline function specifiers Herve Codina
2023-09-12 8:14 ` [PATCH v5 06/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Fix example property name Herve Codina
2023-09-12 16:36 ` Conor Dooley
2023-09-12 8:14 ` [PATCH v5 07/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add 'additionalProperties: false' in child nodes Herve Codina
2023-09-12 16:37 ` Conor Dooley
2023-09-12 18:23 ` Rob Herring
2023-09-12 10:10 ` [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC Herve Codina
2023-09-12 17:21 ` Conor Dooley
2023-09-13 7:26 ` Herve Codina
2023-09-13 14:42 ` Conor Dooley [this message]
2023-09-13 14:52 ` Herve Codina
2023-09-13 14:56 ` Conor Dooley
2023-09-13 14:59 ` Conor Dooley
2023-09-18 7:42 ` Herve Codina
2023-09-12 10:11 ` [PATCH v5 09/31] soc: fsl: cpm1: qmc: Add support for child devices Herve Codina
2023-09-12 10:12 ` [PATCH v5 10/31] net: wan: Add support for QMC HDLC Herve Codina
2023-09-12 10:12 ` [PATCH v5 11/31] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2023-09-12 10:13 ` [PATCH v5 12/31] soc: fsl: cpm1: qmc: Introduce available timeslots masks Herve Codina
2023-09-12 10:13 ` [PATCH v5 13/31] soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* Herve Codina
2023-09-12 10:13 ` [PATCH v5 14/31] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* Herve Codina
2023-09-12 10:13 ` [PATCH v5 15/31] soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() Herve Codina
2023-09-12 10:13 ` [PATCH v5 16/31] soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() Herve Codina
2023-09-12 10:13 ` [PATCH v5 17/31] soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries Herve Codina
2023-09-12 10:13 ` [PATCH v5 18/31] soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup Herve Codina
2023-09-12 10:14 ` [PATCH v5 19/31] soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag Herve Codina
2023-09-12 10:14 ` [PATCH v5 20/31] soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() Herve Codina
2023-09-12 10:14 ` [PATCH v5 21/31] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Herve Codina
2023-09-12 10:14 ` [PATCH v5 22/31] soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime Herve Codina
2023-09-12 10:14 ` [PATCH v5 23/31] wan: qmc_hdlc: Add runtime timeslots changes support Herve Codina
2023-09-12 10:14 ` [PATCH v5 24/31] net: wan: Add framer framework support Herve Codina
2023-09-13 16:59 ` Mark Brown
2023-09-12 10:14 ` [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Herve Codina
2023-09-12 18:13 ` Conor Dooley
2023-09-12 18:49 ` Christophe Leroy
2023-09-18 7:49 ` Herve Codina
2023-09-18 8:02 ` Herve Codina
2023-09-21 8:45 ` Christophe Leroy
[not found] ` <20230912185405.GA1165807-robh@kernel.org>
2023-09-13 14:39 ` Conor Dooley
2023-09-12 10:14 ` [PATCH v5 26/31] mfd: core: Ensure disabled devices are skipped without aborting Herve Codina
2023-09-12 10:14 ` [PATCH v5 27/31] net: wan: framer: Add support for the Lantiq PEF2256 framer Herve Codina
2023-09-12 10:50 ` Linus Walleij
2023-09-12 10:15 ` [PATCH v5 28/31] pinctrl: Add support for the Lantic PEF2256 pinmux Herve Codina
2023-09-12 11:04 ` Linus Walleij
2023-09-12 14:31 ` Mark Brown
2023-09-12 21:04 ` Linus Walleij
2023-09-18 8:35 ` Herve Codina
2023-09-12 10:15 ` [PATCH v5 29/31] MAINTAINERS: Add the Lantiq PEF2256 driver entry Herve Codina
2023-09-12 11:05 ` Linus Walleij
2023-09-12 10:15 ` [PATCH v5 30/31] ASoC: codecs: Add support for the framer codec Herve Codina
2023-09-12 10:15 ` [PATCH v5 31/31] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913-unruly-recite-7dbbbd7e63e0@spud \
--to=conor@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=horms@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=qiang.zhao@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).