From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Paul Cercueil <paul@crapouillou.net>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Daniel Scally <djrscally@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org,
linux-mtd@lists.infradead.org,
platform-driver-x86@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 0/5] gpio: remove gpiod_toggle_active_low()
Date: Wed, 13 Sep 2023 13:49:56 +0200 [thread overview]
Message-ID: <20230913115001.23183-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The semantics of gpiod_toggle_active_low() are just bad and in almost
all cases require users to check the current state anyway. Let's replace
it with something clearer and more useful.
For getting this upstream: I'm thinking that I should apply patch 1/5,
provide other subsystems with an immutable tag and then we can apply
patch 5/5 for the next release once first four are in master.
Bartosz Golaszewski (5):
gpiolib: provide gpiod_set_active_[low/high]()
mtd: rawnand: ingenic: use gpiod_set_active_high()
mmc: slot-gpio: use gpiod_set_active_[low|high]()
platform/x86: int3472/discrete: use gpiod_set_active_low()
gpiolib: remove gpiod_toggle_active_low()
drivers/gpio/gpiolib.c | 21 ++++++++++++++-----
drivers/mmc/core/slot-gpio.c | 11 +++++-----
.../mtd/nand/raw/ingenic/ingenic_nand_drv.c | 5 ++---
.../x86/intel/int3472/clk_and_regulator.c | 2 +-
drivers/platform/x86/intel/int3472/led.c | 2 +-
include/linux/gpio/consumer.h | 11 ++++++++--
6 files changed, 34 insertions(+), 18 deletions(-)
--
2.39.2
next reply other threads:[~2023-09-13 11:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 11:49 Bartosz Golaszewski [this message]
2023-09-13 11:49 ` [PATCH 1/5] gpiolib: provide gpiod_set_active_[low/high]() Bartosz Golaszewski
2023-09-13 15:19 ` kernel test robot
2023-09-13 18:41 ` kernel test robot
2023-09-13 19:23 ` kernel test robot
2023-09-13 11:49 ` [PATCH 2/5] mtd: rawnand: ingenic: use gpiod_set_active_high() Bartosz Golaszewski
2023-09-13 12:01 ` Paul Cercueil
2023-09-13 15:37 ` Miquel Raynal
2023-09-13 20:05 ` Andy Shevchenko
2023-09-13 20:12 ` Linus Walleij
2023-09-13 20:23 ` Miquel Raynal
2023-09-14 7:02 ` Andy Shevchenko
2023-09-14 7:04 ` Andy Shevchenko
2023-09-14 8:30 ` Paul Cercueil
2023-09-14 9:30 ` Bartosz Golaszewski
2023-09-14 13:55 ` Linus Walleij
2023-09-13 11:49 ` [PATCH 3/5] mmc: slot-gpio: use gpiod_set_active_[low|high]() Bartosz Golaszewski
2023-09-13 12:24 ` Linus Walleij
2023-09-13 12:39 ` Bartosz Golaszewski
2023-09-14 8:31 ` Linus Walleij
2023-09-14 8:38 ` Linus Walleij
2023-09-13 11:50 ` [PATCH 4/5] platform/x86: int3472/discrete: use gpiod_set_active_low() Bartosz Golaszewski
2023-09-13 14:50 ` Hans de Goede
2023-09-13 11:50 ` [PATCH 5/5] gpiolib: remove gpiod_toggle_active_low() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913115001.23183-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=djrscally@gmail.com \
--cc=harveyhuntnexus@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=markgross@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=paul@crapouillou.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=richard@nod.at \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).