From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v3 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find()
Date: Fri, 15 Sep 2023 17:03:24 +0200 [thread overview]
Message-ID: <20230915150327.81918-10-brgl@bgdev.pl> (raw)
In-Reply-To: <20230915150327.81918-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
We're porting all users of gpiochip_find() to using gpio_device_find().
Update the ACPI GPIO code.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpiolib-acpi.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 17a86bdd9609..2378e1e7e8b9 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -143,7 +143,7 @@ static int acpi_gpiochip_find(struct gpio_chip *gc, void *data)
*/
static struct gpio_desc *acpi_get_gpiod(char *path, unsigned int pin)
{
- struct gpio_chip *chip;
+ struct gpio_device *gdev __free(gpio_device_put) = NULL;
acpi_handle handle;
acpi_status status;
@@ -151,11 +151,15 @@ static struct gpio_desc *acpi_get_gpiod(char *path, unsigned int pin)
if (ACPI_FAILURE(status))
return ERR_PTR(-ENODEV);
- chip = gpiochip_find(handle, acpi_gpiochip_find);
- if (!chip)
+ gdev = gpio_device_find(handle, acpi_gpiochip_find);
+ if (!gdev)
return ERR_PTR(-EPROBE_DEFER);
- return gpiochip_get_desc(chip, pin);
+ /*
+ * FIXME: keep track of the reference to the GPIO device somehow
+ * instead of putting it here.
+ */
+ return gpio_device_get_desc(gdev, pin);
}
/**
--
2.39.2
next prev parent reply other threads:[~2023-09-15 15:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 15:03 [PATCH v3 00/11] gpiolib: work towards removing gpiochip_find() Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 01/11] gpiolib: make gpio_device_get() and gpio_device_put() public Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 02/11] gpiolib: add support for scope-based management to gpio_device Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 03/11] gpiolib: provide gpio_device_find() Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 04/11] gpiolib: provide gpio_device_find_by_label() Bartosz Golaszewski
2023-09-18 7:19 ` Andy Shevchenko
2023-09-27 11:22 ` Bartosz Golaszewski
2023-09-27 12:33 ` Andy Shevchenko
2023-09-27 12:42 ` Bartosz Golaszewski
2023-09-27 13:48 ` Andy Shevchenko
2023-09-27 13:57 ` Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 05/11] gpiolib: provide gpio_device_get_desc() Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 06/11] gpiolib: reluctantly provide gpio_device_get_chip() Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 07/11] gpiolib: replace find_chip_by_name() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-18 7:22 ` Andy Shevchenko
2023-09-18 8:03 ` Bartosz Golaszewski
2023-09-20 9:01 ` Linus Walleij
2023-09-15 15:03 ` [PATCH v3 08/11] gpio: of: replace gpiochip_find_* with gpio_device_find_* Bartosz Golaszewski
2023-09-15 15:03 ` Bartosz Golaszewski [this message]
2023-09-18 5:29 ` [PATCH v3 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find() Mika Westerberg
2023-09-15 15:03 ` [PATCH v3 10/11] gpio: swnode: replace gpiochip_find() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-18 7:25 ` Andy Shevchenko
2023-09-18 8:04 ` Bartosz Golaszewski
2023-09-15 15:03 ` [PATCH v3 11/11] gpio: sysfs: drop the mention of gpiochip_find() from sysfs code Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915150327.81918-10-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).