* [PATCH v1 1/1] gpiolib: cdev: Annotate struct linereq with __counted_by()
@ 2023-09-18 9:15 Andy Shevchenko
2023-09-25 6:54 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2023-09-18 9:15 UTC (permalink / raw)
To: Bartosz Golaszewski, linux-gpio, linux-kernel, llvm
Cc: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko,
Nathan Chancellor, Nick Desaulniers, Tom Rix, Andy Shevchenko
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpiolib-cdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index a5bbbd44531f..e23f06f58234 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -572,7 +572,7 @@ struct linereq {
DECLARE_KFIFO_PTR(events, struct gpio_v2_line_event);
atomic_t seqno;
struct mutex config_mutex;
- struct line lines[];
+ struct line lines[] __counted_by(num_lines);
};
#define GPIO_V2_LINE_BIAS_FLAGS \
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] gpiolib: cdev: Annotate struct linereq with __counted_by()
2023-09-18 9:15 [PATCH v1 1/1] gpiolib: cdev: Annotate struct linereq with __counted_by() Andy Shevchenko
@ 2023-09-25 6:54 ` Andy Shevchenko
2023-09-25 17:17 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2023-09-25 6:54 UTC (permalink / raw)
To: Bartosz Golaszewski, linux-gpio, linux-kernel, llvm
Cc: Linus Walleij, Bartosz Golaszewski, Nathan Chancellor,
Nick Desaulniers, Tom Rix
On Mon, Sep 18, 2023 at 12:15:53PM +0300, Andy Shevchenko wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
Kees' patch is better, please ignore this one.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] gpiolib: cdev: Annotate struct linereq with __counted_by()
2023-09-25 6:54 ` Andy Shevchenko
@ 2023-09-25 17:17 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2023-09-25 17:17 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bartosz Golaszewski, linux-gpio, linux-kernel, llvm,
Linus Walleij, Bartosz Golaszewski, Nathan Chancellor,
Nick Desaulniers, Tom Rix
On Mon, Sep 25, 2023 at 09:54:34AM +0300, Andy Shevchenko wrote:
> On Mon, Sep 18, 2023 at 12:15:53PM +0300, Andy Shevchenko wrote:
> > Prepare for the coming implementation by GCC and Clang of the __counted_by
> > attribute. Flexible array members annotated with __counted_by can have
> > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
>
> Kees' patch is better, please ignore this one.
Oh! I didn't get CCed so I didn't know you'd sent this. :)
Thanks for taking the initiative on this, though! (But, yes,
initialization order matters.)
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-25 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-18 9:15 [PATCH v1 1/1] gpiolib: cdev: Annotate struct linereq with __counted_by() Andy Shevchenko
2023-09-25 6:54 ` Andy Shevchenko
2023-09-25 17:17 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).