From: Rob Herring <robh@kernel.org>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups
Date: Mon, 18 Sep 2023 16:12:02 -0500 [thread overview]
Message-ID: <20230918211202.GA1743810-robh@kernel.org> (raw)
In-Reply-To: <20230917162837.277405-2-arinc.unal@arinc9.com>
On Sun, Sep 17, 2023 at 07:28:37PM +0300, Arınç ÜNAL wrote:
> Document the pins of each group on the MediaTek MTMIPS SoC pin controllers.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> .../pinctrl/mediatek,mt7620-pinctrl.yaml | 22 ++++++++++++-
> .../pinctrl/mediatek,mt7621-pinctrl.yaml | 18 +++++++++-
> .../pinctrl/mediatek,mt76x8-pinctrl.yaml | 33 ++++++++++++++++++-
> .../pinctrl/ralink,rt2880-pinctrl.yaml | 17 +++++++++-
> .../pinctrl/ralink,rt305x-pinctrl.yaml | 16 ++++++++-
> .../pinctrl/ralink,rt3352-pinctrl.yaml | 17 +++++++++-
> .../pinctrl/ralink,rt3883-pinctrl.yaml | 16 ++++++++-
> .../pinctrl/ralink,rt5350-pinctrl.yaml | 13 +++++++-
> 8 files changed, 144 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> index 221adcef6e14..eb9d9d2bd90f 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> @@ -44,8 +44,28 @@ patternProperties:
> wdt refclk, wdt rst, wled]
>
> groups:
> - description:
> + description: |
> An array of strings. Each string contains the name of a group.
> +
> + group pins
> + ------------------------------------------------------------------
> + "i2c" 1, 2
> + "spi" 3, 4, 5, 6
> + "uartf" 7, 8, 9, 10, 11, 12, 13, 14
> + "uartlite" 15, 16
> + "wdt" 17
> + "pa" 18, 19, 20, 21
> + "mdio" 22, 23
> + "rgmii1" 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35
> + "pcie" 36
> + "spi refclk" 37, 38, 39
> + "ephy" 40, 41, 42, 43, 44
> + "nd_sd" 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56,
> + 57, 58, 59
> +
> + "rgmii2" 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71
> + "wled" 72
This list of strings should be an enum like 'function' above.
> +
> maxItems: 1
This is wrong if more than 1 string is allowed...
Same goes for the rest of the changes.
Rob
next prev parent reply other threads:[~2023-09-18 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 16:28 [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Arınç ÜNAL
2023-09-17 16:28 ` [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Arınç ÜNAL
2023-09-18 8:30 ` Sergio Paracuellos
2023-09-18 21:12 ` Rob Herring [this message]
2023-09-18 8:29 ` [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Sergio Paracuellos
2023-09-18 20:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918211202.GA1743810-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=erkin.bozoglu@xeront.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).