linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux
@ 2023-09-17 16:28 Arınç ÜNAL
  2023-09-17 16:28 ` [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Arınç ÜNAL
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Arınç ÜNAL @ 2023-09-17 16:28 UTC (permalink / raw)
  To: Arınç ÜNAL, Sergio Paracuellos, Linus Walleij,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno
  Cc: mithat.guner, erkin.bozoglu, linux-mediatek, linux-mips,
	linux-gpio, devicetree, linux-kernel, linux-arm-kernel

The "ralink,rt2880-pinmux" compatible string applies to all MediaTek MTMIPS
SoC pin controllers. Add it as a deprecated compatible string.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 .../devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml | 5 ++++-
 .../devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml | 5 ++++-
 .../devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml | 5 ++++-
 .../devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml   | 5 ++++-
 .../devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml   | 5 ++++-
 .../devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml   | 5 ++++-
 .../devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml   | 5 ++++-
 .../devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml   | 5 ++++-
 8 files changed, 32 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
index 591bc0664ec6..221adcef6e14 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
@@ -17,7 +17,10 @@ description: |
 
 properties:
   compatible:
-    const: ralink,mt7620-pinctrl
+    oneOf:
+      - const: ralink,mt7620-pinctrl
+      - const: ralink,rt2880-pinmux
+        deprecated: true
 
 patternProperties:
   '-pins$':
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml
index e568b9c13727..5e29332c794b 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml
@@ -17,7 +17,10 @@ description: |
 
 properties:
   compatible:
-    const: ralink,mt7621-pinctrl
+    oneOf:
+      - const: ralink,mt7621-pinctrl
+      - const: ralink,rt2880-pinmux
+        deprecated: true
 
 patternProperties:
   '-pins$':
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml
index 31849dd5940b..fef7728a5220 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml
@@ -17,7 +17,10 @@ description: |
 
 properties:
   compatible:
-    const: ralink,mt76x8-pinctrl
+    oneOf:
+      - const: ralink,mt76x8-pinctrl
+      - const: ralink,rt2880-pinmux
+        deprecated: true
 
 patternProperties:
   '-pins$':
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml
index 43b33dbf115b..71bc961b856e 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml
@@ -17,7 +17,10 @@ description: |
 
 properties:
   compatible:
-    const: ralink,rt2880-pinctrl
+    oneOf:
+      - const: ralink,rt2880-pinctrl
+      - const: ralink,rt2880-pinmux
+        deprecated: true
 
 patternProperties:
   '-pins$':
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml
index 95a904273009..bde19a00af80 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml
@@ -17,7 +17,10 @@ description: |
 
 properties:
   compatible:
-    const: ralink,rt305x-pinctrl
+    oneOf:
+      - const: ralink,rt305x-pinctrl
+      - const: ralink,rt2880-pinmux
+        deprecated: true
 
 patternProperties:
   '-pins$':
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml
index c9bc6cfd834c..f87038cadfc8 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml
@@ -17,7 +17,10 @@ description: |
 
 properties:
   compatible:
-    const: ralink,rt3352-pinctrl
+    oneOf:
+      - const: ralink,rt3352-pinctrl
+      - const: ralink,rt2880-pinmux
+        deprecated: true
 
 patternProperties:
   '-pins$':
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml
index 8d14e525b25e..3a13a69f7752 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml
@@ -17,7 +17,10 @@ description: |
 
 properties:
   compatible:
-    const: ralink,rt3883-pinctrl
+    oneOf:
+      - const: ralink,rt3883-pinctrl
+      - const: ralink,rt2880-pinmux
+        deprecated: true
 
 patternProperties:
   '-pins$':
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml
index f248202ce866..1231f442afbc 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml
@@ -17,7 +17,10 @@ description: |
 
 properties:
   compatible:
-    const: ralink,rt5350-pinctrl
+    oneOf:
+      - const: ralink,rt5350-pinctrl
+      - const: ralink,rt2880-pinmux
+        deprecated: true
 
 patternProperties:
   '-pins$':
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups
  2023-09-17 16:28 [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Arınç ÜNAL
@ 2023-09-17 16:28 ` Arınç ÜNAL
  2023-09-18  8:30   ` Sergio Paracuellos
  2023-09-18 21:12   ` Rob Herring
  2023-09-18  8:29 ` [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Sergio Paracuellos
  2023-09-18 20:48 ` Rob Herring
  2 siblings, 2 replies; 6+ messages in thread
From: Arınç ÜNAL @ 2023-09-17 16:28 UTC (permalink / raw)
  To: Arınç ÜNAL, Sergio Paracuellos, Linus Walleij,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno
  Cc: mithat.guner, erkin.bozoglu, linux-mediatek, linux-mips,
	linux-gpio, devicetree, linux-kernel, linux-arm-kernel

Document the pins of each group on the MediaTek MTMIPS SoC pin controllers.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 .../pinctrl/mediatek,mt7620-pinctrl.yaml      | 22 ++++++++++++-
 .../pinctrl/mediatek,mt7621-pinctrl.yaml      | 18 +++++++++-
 .../pinctrl/mediatek,mt76x8-pinctrl.yaml      | 33 ++++++++++++++++++-
 .../pinctrl/ralink,rt2880-pinctrl.yaml        | 17 +++++++++-
 .../pinctrl/ralink,rt305x-pinctrl.yaml        | 16 ++++++++-
 .../pinctrl/ralink,rt3352-pinctrl.yaml        | 17 +++++++++-
 .../pinctrl/ralink,rt3883-pinctrl.yaml        | 16 ++++++++-
 .../pinctrl/ralink,rt5350-pinctrl.yaml        | 13 +++++++-
 8 files changed, 144 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
index 221adcef6e14..eb9d9d2bd90f 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
@@ -44,8 +44,28 @@ patternProperties:
                    wdt refclk, wdt rst, wled]
 
           groups:
-            description:
+            description: |
               An array of strings. Each string contains the name of a group.
+
+              group             pins
+              ------------------------------------------------------------------
+              "i2c"             1, 2
+              "spi"             3, 4, 5, 6
+              "uartf"           7, 8, 9, 10, 11, 12, 13, 14
+              "uartlite"        15, 16
+              "wdt"             17
+              "pa"              18, 19, 20, 21
+              "mdio"            22, 23
+              "rgmii1"          24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35
+              "pcie"            36
+              "spi refclk"      37, 38, 39
+              "ephy"            40, 41, 42, 43, 44
+              "nd_sd"           45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56,
+                                57, 58, 59
+
+              "rgmii2"          60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71
+              "wled"            72
+
             maxItems: 1
 
         required:
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml
index 5e29332c794b..71d1ef203d38 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml
@@ -43,8 +43,24 @@ patternProperties:
                    uart1, uart2, uart3, wdt refclk, wdt rst]
 
           groups:
-            description:
+            description: |
               An array of strings. Each string contains the name of a group.
+
+              group             pins
+              ------------------------------------------------------------------
+              "uart1"           1, 2
+              "i2c"             3, 4
+              "uart3"           5, 6, 7, 8
+              "uart2"           9, 10, 11, 12
+              "jtag"            13, 14, 15, 16, 17
+              "wdt"             18
+              "pcie"            19
+              "mdio"            20, 21
+              "rgmii2"          22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33
+              "spi"             34, 35, 36, 37, 38, 39, 40
+              "sdhci"           41, 42, 43, 44, 45, 46, 47, 48
+              "rgmii1"          49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60
+
             maxItems: 1
 
         required:
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml
index fef7728a5220..3831c04fa37c 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml
@@ -46,8 +46,39 @@ patternProperties:
                    wled_an, wled_kn, -]
 
           groups:
-            description:
+            description: |
               An array of strings. Each string contains the name of a group.
+
+              group             pins
+              ------------------------------------------------------------------
+              "i2s"             0, 1, 2, 3
+              "i2c"             4, 5
+              "spi cs1"         6
+              "spi"             7, 8, 9, 10
+              "gpio"            11
+              "uart0"           12, 13
+              "spis"            14, 15, 16, 17
+              "pwm0"            18
+              "pwm1"            19
+              "uart2"           20, 21
+              "sdmode"          22, 23, 24, 25, 26, 27, 28, 29
+              "p4led_kn"        30
+              "p3led_kn"        31
+              "p2led_kn"        32
+              "p1led_kn"        33
+              "p0led_kn"        34
+              "wled_kn"         35
+              "perst"           36
+              "refclk"          37
+              "wdt"             38
+              "p4led_an"        39
+              "p3led_an"        40
+              "p2led_an"        41
+              "p1led_an"        42
+              "p0led_an"        43
+              "wled_an"         44
+              "uart1"           45, 46
+
             maxItems: 1
 
         required:
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml
index 71bc961b856e..b1a6a6236737 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml
@@ -41,8 +41,23 @@ patternProperties:
             enum: [gpio, i2c, spi, uartlite, jtag, mdio, sdram, pci]
 
           groups:
-            description:
+            description: |
               An array of strings. Each string contains the name of a group.
+
+              group             pins
+              ------------------------------------------------------------------
+              "i2c"             1, 2
+              "spi"             3, 4, 5, 6
+              "uartlite"        7, 8, 9, 10, 11, 12, 13, 14
+              "jtag"            17, 18, 19, 20, 21
+              "mdio"            22, 23
+              "sdram"           24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35,
+                                36, 37, 38, 39
+
+              "pci"             40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51,
+                                52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63,
+                                64, 65, 66, 67, 68, 69, 70, 71
+
             maxItems: 1
 
         required:
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml
index bde19a00af80..214fb17d6b82 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml
@@ -43,8 +43,22 @@ patternProperties:
                    uartlite]
 
           groups:
-            description:
+            description: |
               An array of strings. Each string contains the name of a group.
+
+              group             pins
+              ------------------------------------------------------------------
+              "i2c"             1, 2
+              "spi"             3, 4, 5, 6
+              "uartf"           7, 8, 9, 10, 11, 12, 13, 14
+              "uartlite"        15, 16
+              "jtag"            17, 18, 19, 20, 21
+              "mdio"            22, 23
+              "sdram"           24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35,
+                                36, 37, 38, 39
+
+              "rgmii"           40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51
+
             maxItems: 1
 
         required:
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml
index f87038cadfc8..65f04d85e9fc 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml
@@ -43,8 +43,23 @@ patternProperties:
                    uartf, uartlite, wdg_cs1]
 
           groups:
-            description:
+            description: |
               An array of strings. Each string contains the name of a group.
+
+              group             pins
+              ------------------------------------------------------------------
+              "i2c"             1, 2
+              "spi"             3, 4, 5, 6
+              "uartf"           7, 8, 9, 10, 11, 12, 13, 14
+              "uartlite"        15, 16
+              "jtag"            17, 18, 19, 20, 21
+              "mdio"            22, 23
+              "rgmii"           24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35
+              "lna"             36, 37
+              "pa"              38, 39
+              "led"             40, 41, 42, 43, 44
+              "spi_cs1"         45
+
             maxItems: 1
 
         required:
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml
index 3a13a69f7752..61beb78b9d1c 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml
@@ -43,8 +43,22 @@ patternProperties:
                    pcm gpio, pcm i2s, pcm uartf, spi, uartf, uartlite]
 
           groups:
-            description:
+            description: |
               An array of strings. Each string contains the name of a group.
+
+              group             pins
+              ------------------------------------------------------------------
+              "i2c"             1, 2
+              "spi"             3, 4, 5, 6
+              "uartf"           7, 8, 9, 10, 11, 12, 13, 14
+              "uartlite"        15, 16
+              "jtag"            17, 18, 19, 20, 21
+              "mdio"            22, 23
+              "lna a"           32, 33, 34
+              "lna g"           35, 36, 37
+              "ge1"             72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83
+              "ge2"             84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95
+
             maxItems: 1
 
         required:
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml
index 1231f442afbc..49025783247e 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml
@@ -43,8 +43,19 @@ patternProperties:
                    wdg_cs1]
 
           groups:
-            description:
+            description: |
               An array of strings. Each string contains the name of a group.
+
+              group             pins
+              ------------------------------------------------------------------
+              "i2c"             1, 2
+              "spi"             3, 4, 5, 6
+              "uartf"           7, 8, 9, 10, 11, 12, 13, 14
+              "uartlite"        15, 16
+              "jtag"            17, 18, 19, 20, 21
+              "led"             22, 23, 24, 25, 26
+              "spi_cs1"         27
+
             maxItems: 1
 
         required:
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux
  2023-09-17 16:28 [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Arınç ÜNAL
  2023-09-17 16:28 ` [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Arınç ÜNAL
@ 2023-09-18  8:29 ` Sergio Paracuellos
  2023-09-18 20:48 ` Rob Herring
  2 siblings, 0 replies; 6+ messages in thread
From: Sergio Paracuellos @ 2023-09-18  8:29 UTC (permalink / raw)
  To: Arınç ÜNAL
  Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno, mithat.guner,
	erkin.bozoglu, linux-mediatek, linux-mips, linux-gpio, devicetree,
	linux-kernel, linux-arm-kernel

On Sun, Sep 17, 2023 at 6:29 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> The "ralink,rt2880-pinmux" compatible string applies to all MediaTek MTMIPS
> SoC pin controllers. Add it as a deprecated compatible string.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  .../devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml | 5 ++++-
>  .../devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml | 5 ++++-
>  .../devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml   | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml   | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml   | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml   | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml   | 5 ++++-
>  8 files changed, 32 insertions(+), 8 deletions(-)

Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups
  2023-09-17 16:28 ` [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Arınç ÜNAL
@ 2023-09-18  8:30   ` Sergio Paracuellos
  2023-09-18 21:12   ` Rob Herring
  1 sibling, 0 replies; 6+ messages in thread
From: Sergio Paracuellos @ 2023-09-18  8:30 UTC (permalink / raw)
  To: Arınç ÜNAL
  Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno, mithat.guner,
	erkin.bozoglu, linux-mediatek, linux-mips, linux-gpio, devicetree,
	linux-kernel, linux-arm-kernel

On Sun, Sep 17, 2023 at 6:30 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> Document the pins of each group on the MediaTek MTMIPS SoC pin controllers.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  .../pinctrl/mediatek,mt7620-pinctrl.yaml      | 22 ++++++++++++-
>  .../pinctrl/mediatek,mt7621-pinctrl.yaml      | 18 +++++++++-
>  .../pinctrl/mediatek,mt76x8-pinctrl.yaml      | 33 ++++++++++++++++++-
>  .../pinctrl/ralink,rt2880-pinctrl.yaml        | 17 +++++++++-
>  .../pinctrl/ralink,rt305x-pinctrl.yaml        | 16 ++++++++-
>  .../pinctrl/ralink,rt3352-pinctrl.yaml        | 17 +++++++++-
>  .../pinctrl/ralink,rt3883-pinctrl.yaml        | 16 ++++++++-
>  .../pinctrl/ralink,rt5350-pinctrl.yaml        | 13 +++++++-
>  8 files changed, 144 insertions(+), 8 deletions(-)

Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux
  2023-09-17 16:28 [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Arınç ÜNAL
  2023-09-17 16:28 ` [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Arınç ÜNAL
  2023-09-18  8:29 ` [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Sergio Paracuellos
@ 2023-09-18 20:48 ` Rob Herring
  2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-09-18 20:48 UTC (permalink / raw)
  To: Arınç ÜNAL
  Cc: Krzysztof Kozlowski, erkin.bozoglu, linux-mediatek,
	linux-arm-kernel, devicetree, Linus Walleij, Conor Dooley,
	Rob Herring, Matthias Brugger, Sergio Paracuellos, linux-gpio,
	linux-kernel, AngeloGioacchino Del Regno, mithat.guner,
	linux-mips


On Sun, 17 Sep 2023 19:28:36 +0300, Arınç ÜNAL wrote:
> The "ralink,rt2880-pinmux" compatible string applies to all MediaTek MTMIPS
> SoC pin controllers. Add it as a deprecated compatible string.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  .../devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml | 5 ++++-
>  .../devicetree/bindings/pinctrl/mediatek,mt7621-pinctrl.yaml | 5 ++++-
>  .../devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml   | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml   | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt3352-pinctrl.yaml   | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml   | 5 ++++-
>  .../devicetree/bindings/pinctrl/ralink,rt5350-pinctrl.yaml   | 5 ++++-
>  8 files changed, 32 insertions(+), 8 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups
  2023-09-17 16:28 ` [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Arınç ÜNAL
  2023-09-18  8:30   ` Sergio Paracuellos
@ 2023-09-18 21:12   ` Rob Herring
  1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-09-18 21:12 UTC (permalink / raw)
  To: Arınç ÜNAL
  Cc: Sergio Paracuellos, Linus Walleij, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	mithat.guner, erkin.bozoglu, linux-mediatek, linux-mips,
	linux-gpio, devicetree, linux-kernel, linux-arm-kernel

On Sun, Sep 17, 2023 at 07:28:37PM +0300, Arınç ÜNAL wrote:
> Document the pins of each group on the MediaTek MTMIPS SoC pin controllers.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  .../pinctrl/mediatek,mt7620-pinctrl.yaml      | 22 ++++++++++++-
>  .../pinctrl/mediatek,mt7621-pinctrl.yaml      | 18 +++++++++-
>  .../pinctrl/mediatek,mt76x8-pinctrl.yaml      | 33 ++++++++++++++++++-
>  .../pinctrl/ralink,rt2880-pinctrl.yaml        | 17 +++++++++-
>  .../pinctrl/ralink,rt305x-pinctrl.yaml        | 16 ++++++++-
>  .../pinctrl/ralink,rt3352-pinctrl.yaml        | 17 +++++++++-
>  .../pinctrl/ralink,rt3883-pinctrl.yaml        | 16 ++++++++-
>  .../pinctrl/ralink,rt5350-pinctrl.yaml        | 13 +++++++-
>  8 files changed, 144 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> index 221adcef6e14..eb9d9d2bd90f 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> @@ -44,8 +44,28 @@ patternProperties:
>                     wdt refclk, wdt rst, wled]
>  
>            groups:
> -            description:
> +            description: |
>                An array of strings. Each string contains the name of a group.
> +
> +              group             pins
> +              ------------------------------------------------------------------
> +              "i2c"             1, 2
> +              "spi"             3, 4, 5, 6
> +              "uartf"           7, 8, 9, 10, 11, 12, 13, 14
> +              "uartlite"        15, 16
> +              "wdt"             17
> +              "pa"              18, 19, 20, 21
> +              "mdio"            22, 23
> +              "rgmii1"          24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35
> +              "pcie"            36
> +              "spi refclk"      37, 38, 39
> +              "ephy"            40, 41, 42, 43, 44
> +              "nd_sd"           45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56,
> +                                57, 58, 59
> +
> +              "rgmii2"          60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71
> +              "wled"            72

This list of strings should be an enum like 'function' above.

> +
>              maxItems: 1

This is wrong if more than 1 string is allowed...

Same goes for the rest of the changes.

Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-09-18 21:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-17 16:28 [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Arınç ÜNAL
2023-09-17 16:28 ` [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Arınç ÜNAL
2023-09-18  8:30   ` Sergio Paracuellos
2023-09-18 21:12   ` Rob Herring
2023-09-18  8:29 ` [PATCH 1/2] dt-bindings: pinctrl: mtmips: add deprecated ralink,rt2880-pinmux Sergio Paracuellos
2023-09-18 20:48 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).