From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 118B7CD54A9 for ; Tue, 19 Sep 2023 09:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbjISJEQ (ORCPT ); Tue, 19 Sep 2023 05:04:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjISJEQ (ORCPT ); Tue, 19 Sep 2023 05:04:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE192E6; Tue, 19 Sep 2023 02:04:10 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE739C433C8; Tue, 19 Sep 2023 09:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695114250; bh=0HoaoIryoMNBjclA4E9p8j1l8zhUoytllUXAdhNwV5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b/l9gCQ0T8EvqzJqFrQ5of1NAyiceRmdIutxOzP5nFXj3+C2NovgXilDrksFhbwvr O2trT4x5qScyykTeTddgKkJ2NlqZDVkjd4SgU/cCUlaqymPUgEUXTPUFeKvGo8lScP GZhlgg0D2BhDqV/cJGjDZ57+o1v4sJPpkJzlTD6KFHl2Kfor2bSkNVksRaj0EyRNbe DMS8CrGEZx1spG8Biu/A6bqshM5iuBDdWbOcp6xHWhWRKbCSO+vcn7DRXbGaa/XVxi I2qgLNA3dlYfDkC8y/XoLajqwQBijGz6LRnyVp9+yljnrCyDegNBSYRkf9ASlkdT9h imjCEN7Pb+nzA== Date: Tue, 19 Sep 2023 10:04:04 +0100 From: Conor Dooley To: "Peng Fan (OSS)" Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH v3 4/6] gpio: vf610: add i.MX8ULP of_device_id entry Message-ID: <20230919-501837c1104366ba793b0c62@fedora> References: <20230918-vf610-gpio-v3-0-ada82a17adc5@nxp.com> <20230918-vf610-gpio-v3-4-ada82a17adc5@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5zdzlSUyqQ668/XK" Content-Disposition: inline In-Reply-To: <20230918-vf610-gpio-v3-4-ada82a17adc5@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --5zdzlSUyqQ668/XK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 18, 2023 at 04:16:08PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan >=20 > i.MX8ULP GPIO supports similar feature as i.MX7ULP GPIO, but i.MX8ULP is > not compatible with i.MX7ULP per binding doc. i.MX8ULP only has one > register base, not two base. "per binding doc" is a poor justification IMO, as you literally just changed it earlier in this series. I think the commit message here should re-explain the problem so that the rationale here is clear in isolation. > Add a new of_device_id entry for i.MX8ULP. But to make the driver could > also support old bindings, check the compatible string first, before > check the device data. Sweet, seems like you have addressed the backwards compatibility stuff for the old binding :) Thanks, Conor. --5zdzlSUyqQ668/XK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQlkAQAKCRB4tDGHoIJi 0rb8AP993AO2r6CSvVZx8F5s5DBodTKq3cEDVHeH6mdCJSOgpwD/Xiq7LXIzgBfZ 6S8r4rMkPZAmZwZvNhTjZVidIH6ZYwg= =PSDM -----END PGP SIGNATURE----- --5zdzlSUyqQ668/XK--